Skip to content

Commit 3684707

Browse files
committed
Adding wait for installation and improving drone.yml
1 parent 4dceb37 commit 3684707

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

.drone.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,26 @@ kind: pipeline
33
name: default
44

55
clone:
6-
depth: 42
76

87
steps:
98
- name: composer
10-
image: joomlaprojects/docker-tools:develop
9+
image: joomlaprojects/docker-images:php7.4
10+
volumes:
11+
- name: composer-cache
12+
path: /tmp/composer-cache
1113
commands:
1214
- composer validate --no-check-all --strict
1315
- composer install --no-progress --no-suggest
1416

1517
- name: phpcs
16-
image: joomlaprojects/docker-images:php7.2
18+
image: joomlaprojects/docker-images:php7.4
1719
commands:
1820
- echo $(date)
1921
- ./vendor/bin/phpcs --extensions=php -p --standard=vendor/joomla/coding-standards/Joomla src
2022
- echo $(date)
2123

2224
---
2325
kind: signature
24-
hmac: 6938afe15e326bcf67fdbb386c1b98cebe6b379b3cf4b08d93e5d8f4ded329e6
26+
hmac: 87b066184613e920466064596cfde1fb9e7aae0ed7ca860ac91c7f199fc3e67f
2527

2628
...

src/JoomlaBrowser.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -237,12 +237,11 @@ public function installJoomla()
237237
$this->debug('I wait for Main Configuration');
238238
$this->waitForElement('#jform_language', 10);
239239
$this->debug('Wait for chosen to render the Languages list field');
240-
$this->wait(2);
241-
242-
// Wait for chosen to render the field
240+
$this->wait(1);
243241
$this->debug('I select en-GB as installation language');
244-
$this->debug('Wait for chosen to render the Languages list field');
245242
$this->selectOption('#jform_language', 'English (United Kingdom)');
243+
$this->wait(2);
244+
$this->debug('Wait for the page to reload in the selected language');
246245
$this->debug('I fill Site Name');
247246
$this->fillField(['id' => 'jform_site_name'], 'Joomla CMS test');
248247
$this->click(['id' => 'step1']);

0 commit comments

Comments
 (0)