Fixing the Xpath for Install Button

puneet0191 · puneet0191 · commit 9b8ebf4541bc · 2015-09-03T17:48:32.000+05:30
diff --git a/src/JoomlaBrowser.php b/src/JoomlaBrowser.php
@@ -329,7 +329,7 @@ public function installExtensionFromFolder($path, $type = 'Extension')
 		$this->debug('I enter the Path');
 		$I->fillField(['id' => 'install_directory'], $path);
 		// @todo: we need to find a better locator for the following Install button
-		$I->click(['xpath' => "//input[contains(@onclick,'Joomla.submitbutton3()')]"]); // Install button
+		$I->click(['xpath' => "//button[contains(@onclick,'Joomla.submitbutton3()')]"]); // Install button
 		$I->waitForText('was successful','30', ['id' => 'system-message-container']);
 		$this->debug("$type successfully installed from $path");
 	}

Original file line number	Diff line number	Diff line change
`@@ -329,7 +329,7 @@ public function installExtensionFromFolder($path, $type = 'Extension')`
`329`	`329`	`$this->debug('I enter the Path');`
`330`	`330`	`$I->fillField(['id' => 'install_directory'], $path);`
`331`	`331`	`// @todo: we need to find a better locator for the following Install button`
`332`		`- $I->click(['xpath' => "//input[contains(@onclick,'Joomla.submitbutton3()')]"]); // Install button`
	`332`	`+ $I->click(['xpath' => "//button[contains(@onclick,'Joomla.submitbutton3()')]"]); // Install button`
`333`	`333`	`$I->waitForText('was successful','30', ['id' => 'system-message-container']);`
`334`	`334`	`$this->debug("$type successfully installed from $path");`
`335`	`335`	`}`