Merge pull request #175 from jatitoam/session-test

puneet0191 · web-flow · commit ed91ce2021e0 · 2018-08-07T11:24:34.000+05:30
[fix] Ensured the login page is loaded before looking for cookies
diff --git a/src/JoomlaBrowser.php b/src/JoomlaBrowser.php
@@ -123,13 +123,14 @@ public function doAdministratorLogin($user = null, $password = null, $useSnapsho
 			$password = $this->config['password'];
 		}
 
+		$this->debug('I open Joomla Administrator Login Page');
+		$this->amOnPage($this->locator->adminLoginPageUrl);
+
 		if ($useSnapshot && $this->loadSessionSnapshot($user))
 		{
 			return;
 		}
 
-		$this->debug('I open Joomla Administrator Login Page');
-		$this->amOnPage($this->locator->adminLoginPageUrl);
 		$this->waitForElement($this->locator->adminLoginUserName, TIMEOUT);
 		$this->debug('Fill Username Text Field');
 		$this->fillField($this->locator->adminLoginUserName, $user);

Original file line number	Diff line number	Diff line change
`@@ -123,13 +123,14 @@ public function doAdministratorLogin($user = null, $password = null, $useSnapsho`
`123`	`123`	`$password = $this->config['password'];`
`124`	`124`	`}`
`125`	`125`
	`126`	`+ $this->debug('I open Joomla Administrator Login Page');`
	`127`	`+ $this->amOnPage($this->locator->adminLoginPageUrl);`
	`128`	`+`
`126`	`129`	`if ($useSnapshot && $this->loadSessionSnapshot($user))`
`127`	`130`	`{`
`128`	`131`	`return;`
`129`	`132`	`}`
`130`	`133`
`131`		`- $this->debug('I open Joomla Administrator Login Page');`
`132`		`- $this->amOnPage($this->locator->adminLoginPageUrl);`
`133`	`134`	`$this->waitForElement($this->locator->adminLoginUserName, TIMEOUT);`
`134`	`135`	`$this->debug('Fill Username Text Field');`
`135`	`136`	`$this->fillField($this->locator->adminLoginUserName, $user);`