Pass2: gettings packs from github etc.

Author: infograf768

helper.php

@@ -17,7 +17,7 @@ public static function get_Diff_Info(&$params)
 	{
 		require_once(JPATH_ROOT . '/' . 'modules' . '/' . 'mod_ttm_diff_tool_otf' . '/' . 'libraries' . '/' . 'mod_ttm_diff_tool_otf_functions.php');
 		$diff_info = array();
-		$diff_info = get_diff_from_selected_packages($params);
+		$diff_info = ModTtm::get_diff_from_selected_packages($params);
 
 		return $diff_info;
 	}

index.html

@@ -5,7 +5,7 @@
 ;
 
 MOD_TTM_DIFF_TOOL_OTF="TTM diff tool - On The Fly"
-MOD_TTM_DIFF_TOOL_OTF_ACCESS_NOT_ALLOWED="Access not allowed from module config."
+MOD_TTM_DIFF_TOOL_OTF_ACCESS_NOT_ALLOWED="Access forbidden. Check module configuration."
 MOD_TTM_DIFF_TOOL_OTF_ALLOW_HISTORY_DESC="Allows or not to store and use the generated report that the program creates after each diff task.<br />The created file type 'package_name_vs_package_name.ttm' keeps there the escaped HTML info to display so that it will not be necessary to download again from the same revision and recalculate all again.<br />If this option is set to 'No', all starts always from scratch.<br />When set to 'Yes', after rendering the module, a new tab will be present to let handle the stored history (delete the selected ones and keep what you want to keep there)."
 MOD_TTM_DIFF_TOOL_OTF_ALLOW_HISTORY_LABEL="Allow stored history"
 MOD_TTM_DIFF_TOOL_OTF_ALLOWED_GROUPS_TO_HISTORY_DESC="Only the selected groups will have access to view and delete history files."
@@ -22,7 +22,7 @@ MOD_TTM_DIFF_TOOL_OTF_DELETE_SELECTED="Delete selected"
 MOD_TTM_DIFF_TOOL_OTF_DETAILING_CHANGES_COMMON_FILES_BY_CLIENT="DETAILING CHANGES FOR THE COMMON FILES AT THIS CLIENT"
 MOD_TTM_DIFF_TOOL_OTF_DETAILING_NO_CHANGES_COMMON_FILES_BY_CLIENT="NO CHANGES DETECTED FOR THE COMMON FILES AT THIS CLIENT"
 MOD_TTM_DIFF_TOOL_OTF_DETAILING_NEW_FILES_CONTENT="DETAILING THE CONTENT FOR NEW FILES AT THIS CLIENT"
-MOD_TTM_DIFF_TOOL_OTF_ECP_DESC="You can use this when massive changes within commented lines are applied. Use a comma separated list for each word to caths. For example: '2013, 2014' or 'Copyright' (case sensitive) can help to skip all the commented lines related with the new year changes."
+MOD_TTM_DIFF_TOOL_OTF_ECP_DESC="You can use this when massive changes within commented lines are applied. Use a comma separated list for each word to consider. For example: '2013, 2014' or 'Copyright' (case sensitive) can help skipping all the commented lines related with the new year changes."
 MOD_TTM_DIFF_TOOL_OTF_ECP_LABEL="Excluded comments pattern"
 MOD_TTM_DIFF_TOOL_OTF_EMPTY_HISTORY_FOLDER="The history folder is empty."
 MOD_TTM_DIFF_TOOL_OTF_FIELD_MODULE_LAYOUT_DESC="The layout used to show the reported info. Default view is 'Full HTML' output."
@@ -31,7 +31,7 @@ MOD_TTM_DIFF_TOOL_OTF_FILES_ADD_CLIENT="FILES TO ADD IN THE CLIENT "
 MOD_TTM_DIFF_TOOL_OTF_FILES_DELETE_CLIENT="FILES TO DELETE IN THE CLIENT "
 MOD_TTM_DIFF_TOOL_OTF_FILE_CHANGES=" - FILE CHANGES"
 MOD_TTM_DIFF_TOOL_OTF_FROM="From: "
-MOD_TTM_DIFF_TOOL_OTF_FRONZEN_NOT_STORED_URL="* Maybe it is a known frozen Joomla release, but is not stored in this version of the module."
+MOD_TTM_DIFF_TOOL_OTF_FRONZEN_NOT_STORED_URL="* It may be a known frozen Joomla release, but is not stored in this version of the module."
 MOD_TTM_DIFF_TOOL_OTF_GITHUB_NOT_STORED_URL="* The link is not using the module stored way to call the GitHub repository. First 7 digits of SHA id are pointing to real timestamp."
 MOD_TTM_DIFF_TOOL_OTF_HAVE_COMMENTS_TO_ADD="COMMENTS TO ADD"
 MOD_TTM_DIFF_TOOL_OTF_HAVE_COMMENTS_TO_DELETE="COMMENTS TO DELETE"
@@ -48,38 +48,9 @@ MOD_TTM_DIFF_TOOL_OTF_KNOWN_FROZEN_URL="* Known frozen Joomla release."
 MOD_TTM_DIFF_TOOL_OTF_LINE="LINE "
 MOD_TTM_DIFF_TOOL_OTF_MAYBE_FROZEN_URL="* It may be a known frozen Joomla release, but is not stored in this version of the module."
 MOD_TTM_DIFF_TOOL_OTF_NEW="NEW! - "
-MOD_TTM_DIFF_TOOL_OTF_NOT_EVALUATED_FILE="This file is not evaluated because it is an unusual file catched at language location."
+MOD_TTM_DIFF_TOOL_OTF_NOT_EVALUATED_FILE="This file is not evaluated because it is an unusual file catched at the language location."
 MOD_TTM_DIFF_TOOL_OTF_NO_FILES_ADD_CLIENT="* NO FILES TO ADD IN THE CLIENT "
 MOD_TTM_DIFF_TOOL_OTF_NO_FILES_DELETE_CLIENT="* NO FILES TO DELETE IN THE CLIENT "
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_0_0="Joomla 3.0.0"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_0_1="Joomla 3.0.1"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_0_2="Joomla 3.0.2"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_0_3="Joomla 3.0.3"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_1_0="Joomla 3.1.0"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_1_1="Joomla 3.1.1"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_1_4="Joomla 3.1.4"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_1_5="Joomla 3.1.5"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_2_0="Joomla 3.2.0"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_2_1="Joomla 3.2.1"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_2_2="Joomla 3.2.2"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_2_3="Joomla 3.2.3"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_3_0="Joomla 3.3.0"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_3_1="Joomla 3.3.1"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_3_2="Joomla 3.3.2"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_3_3="Joomla 3.3.3"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_3_4="Joomla 3.3.4"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_3_5="Joomla 3.3.5"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_3_6="Joomla 3.3.6"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_4_0="Joomla 3.4.0"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_5_0="Joomla 3.5.0"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_6_0="Joomla 3.6.0"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_7_0="Joomla 3.7.0"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_8_0="Joomla 3.8.0"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_8_1="Joomla 3.8.1"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_8_2="Joomla 3.8.2"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_8_3="Joomla 3.8.3"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_8_4="Joomla 3.8.4"
-MOD_TTM_DIFF_TOOL_OTF_OPTION_STS_FROZEN_3_8_5="Joomla 3.8.5"
 MOD_TTM_DIFF_TOOL_OTF_OPTION_NO="No"
 MOD_TTM_DIFF_TOOL_OTF_OPTION_YES="Yes"
 MOD_TTM_DIFF_TOOL_OTF_ORIENTATIVE_ZIPBALL_URL="* Orientative URL. Type zipball package can to be in continued rolling release and the id within the package name will be changed frequently."
@@ -105,8 +76,6 @@ MOD_TTM_DIFF_TOOL_OTF_TP_NAME="Target package name: "
 MOD_TTM_DIFF_TOOL_OTF_TR_CUSTOM_VALUE_DESC="Use a valid and full URL pointing to the target Joomla pack. Only works when 'Custom - URL to zip file' option is selected from the 'Target package' field."
 MOD_TTM_DIFF_TOOL_OTF_TR_CUSTOM_VALUE_LABEL="Custom target URL"
 MOD_TTM_DIFF_TOOL_OTF_TR_OPTION_CUSTOM="Custom - URL to zip file"
-MOD_TTM_DIFF_TOOL_OTF_TR_OPTION_LTS_DEV="LTS - Last in 2.5.x dev packs"
-MOD_TTM_DIFF_TOOL_OTF_TR_OPTION_LTS_FROZEN="LTS - Stable package"
 MOD_TTM_DIFF_TOOL_OTF_TR_OPTION_STS_DEV="Staging - Last development"
 MOD_TTM_DIFF_TOOL_OTF_TR_OPTION_STS_FROZEN="STS - Stable package"
 MOD_TTM_DIFF_TOOL_OTF_ZIPBALL_NOT_STORED_URL="* Unknown link type zipball not stored by this module version."