URL Field - Multiple issues

[particthistle]

What's wrong?

While reviewing #18, URL field keeps coming back up as an issue.

In the Edit Tour View

URL field on the Tour is the starting point for the tour.

• The URL needs to be a relative URL not an absolute URL.
• The URL field needs to be validated to check it's a relative URL

In the Edit Step View

URL field has disappeared, as has the multipage functionality!

• Looks like you're making the assumption now that all steps apply to the URL for the Tour
• Steps should have a multipage option which then if set to yes conditionally shows the URL field for the step
• Subsequent steps should pick up on that page without needing to specifically have the URL defined for the step

In the default tour installation SQL

URL Field in the INSERT queries for #__tours

• The URL in the default tour installation needs to be relative. Having it install with a localhost URL is incorrect.
• See review of SQL statement for other changes needed to the INSERT queries.

[jatinS-dev]

@particthistle I've implemented the algorithm for multipage functionality in such a way that it doesn't require URL in step to tell that the next step is on a different page.

Users/Developers can directly add the next step on a different pages and Tour will start from that page from the step where it ended on the last page.

[jatinS-dev]

Though we can add the URL field in step form for redirecting purposes. Because there might be some scenarios where the user wants a redirect to happen with the on-click of the next button of the step and wants to start the Tour after that redirect.

[particthistle]

First issues to fix are on the Tour page @jatinS-dev

You have it set at the moment to add http:// when the tour gets saved. This needs to be removed, as otherwise the tour is not going to work. The field needs to be treated as a relative URL without any site prefix information.

I would suggest adding "relative" to the description to so they know it's a relative URL.

[particthistle]

@particthistle I've implemented the algorithm for multipage functionality in such a way that it doesn't require URL in step to tell that the next step is on a different page.

This doesn't make sense @jatinS-dev - HOW do you tell the tour that the next step is on a different page? It should need both the URL and then the target object to attach the step to?

Users/Developers can directly add the next step on a different pages and Tour will start from that page from the step where it ended on the last page.

This doesn't make sense, and certainly is not intuitive from what is in the set of fields for the step.

Eg if you were attaching the step to #thisid, there's nothing in the step to say it's #thisid on another page - it's going to only look for #thisid on the current page that the current step has executed on.