[5.0] Fix wrong language string constant used in database query of privacyconsent task scheduler plugin (#41597)

* Use right language string constant for db query

* Remove obsolete and never released language string

Author: richard67

administrator/language/en-GB/plg_task_privacyconsent.ini

@@ -43,5 +43,4 @@ PLG_TASK_PRIVACYCONSENT_REDIRECT_MESSAGE_DESC="Custom message to be displayed on
 PLG_TASK_PRIVACYCONSENT_REDIRECT_MESSAGE_LABEL="Redirect Message"
 PLG_TASK_PRIVACYCONSENT_REMINDBEFORE_DESC="Number of days to send a reminder before the expiration of the privacy consent."
 PLG_TASK_PRIVACYCONSENT_REMINDBEFORE_LABEL="Remind"
-PLG_TASK_PRIVACYCONSENT_SUBJECT="Privacy Policy"
 PLG_TASK_PRIVACYCONSENT_XML_DESCRIPTION="Task for remind expired consents and delete expired consents"

plugins/task/privacyconsent/src/Extension/PrivacyConsent.php

@@ -127,7 +127,7 @@ private function remindExpiringConsents($expire, $remind): int
         $query->select($db->quoteName(['r.id', 'r.user_id', 'u.email']))
             ->from($db->quoteName('#__privacy_consents', 'r'))
             ->join('LEFT', $db->quoteName('#__users', 'u'), $db->quoteName('u.id') . ' = ' . $db->quoteName('r.user_id'))
-            ->where($db->quoteName('subject') . ' = ' . $db->quote('PLG_TASK_PRIVACYCONSENT_SUBJECT'))
+            ->where($db->quoteName('subject') . ' = ' . $db->quote('PLG_SYSTEM_PRIVACYCONSENT_SUBJECT'))
             ->where($db->quoteName('remind') . ' = 0')
             ->where($query->dateAdd($db->quote($now), $period, 'DAY') . ' > ' . $db->quoteName('created'));
 
@@ -215,7 +215,7 @@ private function invalidateExpiredConsents($expire): int
         $query->select($db->quoteName(['id', 'user_id']))
             ->from($db->quoteName('#__privacy_consents'))
             ->where($query->dateAdd($db->quote($now), $period, 'DAY') . ' > ' . $db->quoteName('created'))
-            ->where($db->quoteName('subject') . ' = ' . $db->quote('PLG_TASK_PRIVACYCONSENT_SUBJECT'))
+            ->where($db->quoteName('subject') . ' = ' . $db->quote('PLG_SYSTEM_PRIVACYCONSENT_SUBJECT'))
             ->where($db->quoteName('state') . ' = 1');
 
         $db->setQuery($query);