Make sure the text files are only generated when needed (#34341)

* Make sure the text files are only generated when needed

* dont generate the hashes for now too

Author: zero-24

build/build.php

@@ -71,6 +71,9 @@ function usage($command)
 $excludeBzip2 = isset($options['exclude-bzip2']);
 $showHelp     = isset($options['help']);
 
+// Disable the generation of extra text files
+$includeExtraTextfiles = false;
+
 if ($showHelp)
 {
 	usage($argv[0]);
@@ -84,6 +87,9 @@ function usage($command)
 	$tagVersion = system($systemGit . ' describe --tags `' . $systemGit . ' rev-list --tags --max-count=1`', $tagVersion);
 	$remote = 'tags/' . $tagVersion;
 	chdir($here);
+
+	// We are in release mode so we need the extra text files
+	$includeExtraTextfiles = true;
 }
 
 echo "Start build for remote $remote.\n";
@@ -392,93 +398,98 @@ function usage($command)
 
 chdir('..');
 
-foreach (array_keys($checksums) as $packageName)
+// Thats only needed when we release a version
+if ($includeExtraTextfiles)
 {
-	echo "Generating checksums for $packageName\n";
 
-	foreach (array('sha256', 'sha384', 'sha512') as $hash)
+	foreach (array_keys($checksums) as $packageName)
 	{
-		if (file_exists('packages/' . $packageName))
-		{
-			$checksums[$packageName][$hash] = hash_file($hash, 'packages/' . $packageName);
-		}
-		else
+		echo "Generating checksums for $packageName\n";
+
+		foreach (array('sha256', 'sha384', 'sha512') as $hash)
 		{
-			echo "Package $packageName not found in build directories\n";
+			if (file_exists('packages/' . $packageName))
+			{
+				$checksums[$packageName][$hash] = hash_file($hash, 'packages/' . $packageName);
+			}
+			else
+			{
+				echo "Package $packageName not found in build directories\n";
+			}
 		}
 	}
-}
 
-echo "Generating checksums.txt file\n";
+	echo "Generating checksums.txt file\n";
 
-$checksumsContent = '';
-
-foreach ($checksums as $packageName => $packageHashes)
-{
-	$checksumsContent .= "Filename: $packageName\n";
+	$checksumsContent = '';
 
-	foreach ($packageHashes as $hashType => $hash)
+	foreach ($checksums as $packageName => $packageHashes)
 	{
-		$checksumsContent .= "$hashType: $hash\n";
-	}
+		$checksumsContent .= "Filename: $packageName\n";
 
-	$checksumsContent .= "\n";
-}
+		foreach ($packageHashes as $hashType => $hash)
+		{
+			$checksumsContent .= "$hashType: $hash\n";
+		}
 
-file_put_contents('checksums.txt', $checksumsContent);
+		$checksumsContent .= "\n";
+	}
 
-echo "Generating github_release.txt file\n";
+	file_put_contents('checksums.txt', $checksumsContent);
 
-$githubContent = array();
-$githubText = '';
-$releaseText = array(
-	'FULL' => 'New Joomla! Installations ',
-	'POINT' => 'Update from Joomla! ' . $version . '.' . $previousRelease . ' ',
-	'MINOR' => 'Update from Joomla! ' . $version . '.x ',
-	'UPGRADE' => 'Update from Joomla! 2.5 or previous 3.x releases ',
-);
-$githubLink = 'https://github.com/joomla/joomla-cms/releases/download/' . $tagVersion . '/';
+	echo "Generating github_release.txt file\n";
 
-foreach ($checksums as $packageName => $packageHashes)
-{
-	$type = '';
+	$githubContent = array();
+	$githubText    = '';
+	$releaseText   = array(
+		'FULL'    => 'New Joomla! Installations ',
+		'POINT'   => 'Update from Joomla! ' . $version . '.' . $previousRelease . ' ',
+		'MINOR'   => 'Update from Joomla! ' . $version . '.x ',
+		'UPGRADE' => 'Update from Joomla! 2.5 or previous 3.x releases ',
+	);
+	$githubLink = 'https://github.com/joomla/joomla-cms/releases/download/' . $tagVersion . '/';
 
-	if (strpos($packageName, 'Full_Package') !== false)
-	{
-		$type = 'FULL';
-	}
-	elseif (strpos($packageName, 'Patch_Package') !== false)
+	foreach ($checksums as $packageName => $packageHashes)
 	{
-		if (strpos($packageName, '.x_to') !== false)
+		$type = '';
+
+		if (strpos($packageName, 'Full_Package') !== false)
 		{
-			$type = 'MINOR';
+			$type = 'FULL';
 		}
-		else
+		elseif (strpos($packageName, 'Patch_Package') !== false)
+		{
+			if (strpos($packageName, '.x_to') !== false)
+			{
+				$type = 'MINOR';
+			}
+			else
+			{
+				$type = 'POINT';
+			}
+		}
+		elseif (strpos($packageName, 'Update_Package') !== false)
 		{
-			$type = 'POINT';
+			$type = 'UPGRADE';
 		}
+
+		$githubContent[$type][] = '[' . substr($packageName, strpos($packageName, 'Package') + 7) . '](' . $githubLink . $packageName . ')';
 	}
-	elseif (strpos($packageName, 'Update_Package') !== false)
+
+	foreach ($releaseText as $type => $text)
 	{
-		$type = 'UPGRADE';
-	}
+		if (empty($githubContent[$type]))
+		{
+			continue;
+		}
 
-	$githubContent[$type][] = '[' . substr($packageName, strpos($packageName, 'Package') + 7) . '](' . $githubLink . $packageName . ')';
-}
+		$githubText .= $text;
+		$githubText .= implode(" | ", $githubContent[$type]);
 
-foreach ($releaseText as $type => $text)
-{
-	if (empty($githubContent[$type]))
-	{
-		continue;
+		$githubText .= "\n";
 	}
 
-	$githubText .= $text;
-	$githubText .= implode(" | ", $githubContent[$type]);
-
-	$githubText .= "\n";
+	file_put_contents('github_release.txt', $githubText);
 }
 
-file_put_contents('github_release.txt', $githubText);
-
 echo "Build of version $fullVersion complete!\n";