[4.0] Smart Search: Fix inserting tokens to DB (#34503)

* Smart Search: Fix inserting tokens to DB

* Update administrator/components/com_finder/src/Indexer/Indexer.php

Co-authored-by: Richard Fath <[email protected]>

Author: Hackwar

administrator/components/com_finder/src/Indexer/Indexer.php

@@ -919,12 +919,19 @@ protected function addTokensToDb($tokens, $context = '')
 
 		$query = clone $this->addTokensToDbQueryTemplate;
 
+		// Check if a single FinderIndexerToken object was given and make it to be an array of FinderIndexerToken objects
+		$tokens = is_array($tokens) ? $tokens : array($tokens);
+
 		// Count the number of token values.
 		$values = 0;
 
-		// Iterate through the tokens to create SQL value sets.
-		if (!is_a($tokens, Token::class))
+		// Break into chunks of no more than 128 items
+		$chunks = array_chunk($tokens, 128);
+
+		foreach ($chunks as $tokens)
 		{
+			$query->clear('values');
+
 			foreach ($tokens as $token)
 			{
 				if ($filterCommon && $token->common)
@@ -946,38 +953,16 @@ protected function addTokensToDb($tokens, $context = '')
 					. (int) $context . ', '
 					. $db->quote($token->language)
 				);
-				$values++;
-
-				if ($values > 0 && ($values % 128) == 0)
-				{
-					$db->setQuery($query)->execute();
-					$query->clear('values');
-
-					// Check if we're approaching the memory limit of the token table.
-					if ($values > static::$state->options->get('memory_table_limit', 10000))
-					{
-						$this->toggleTables(false);
-					}
-				}
+				++$values;
 			}
-		}
-		else
-		{
-			$query->values(
-				$db->quote($tokens->term) . ', '
-				. $db->quote($tokens->stem) . ', '
-				. (int) $tokens->common . ', '
-				. (int) $tokens->phrase . ', '
-				. $db->escape((float) $tokens->weight) . ', '
-				. (int) $context . ', '
-				. $db->quote($tokens->language)
-			);
-			$values++;
-		}
 
-		if ($query->values)
-		{
 			$db->setQuery($query)->execute();
+
+			// Check if we're approaching the memory limit of the token table.
+			if ($values > static::$state->options->get('memory_table_limit', 10000))
+			{
+				$this->toggleTables(false);
+			}
 		}
 
 		return $values;