Remove the deprecated isCli function (#44611)

Thank you @laoneo, one more off the list.

Author: laoneo

installation/src/Application/CliInstallationApplication.php

@@ -311,21 +311,4 @@ public function isClient($identifier)
     {
         return 'cli_installation' === $identifier;
     }
-
-    /**
-     * Flag if the application instance is a CLI or web based application.
-     *
-     * Helper function, you should use the native PHP functions to detect if it is a CLI application.
-     *
-     * @return  boolean
-     *
-     * @since       4.3.0
-     *
-     * @deprecated   4.3 will be removed in 5.0
-     *               Use $app->isClient('cli_installation') instead
-     */
-    public function isCli()
-    {
-        return $this->isClient('cli_installation');
-    }
 }

libraries/src/Application/CMSApplication.php

@@ -1288,23 +1288,6 @@ public function checkToken($method = 'post')
         return $session::checkToken($method);
     }
 
-    /**
-     * Flag if the application instance is a CLI or web based application.
-     *
-     * Helper function, you should use the native PHP functions to detect if it is a CLI application.
-     *
-     * @return  boolean
-     *
-     * @since       4.0.0
-     *
-     * @deprecated  4.0 will be removed in 6.0
-     *              Will be removed without replacements
-     */
-    public function isCli()
-    {
-        return false;
-    }
-
     /**
      * No longer used
      *

libraries/src/Application/CMSApplicationInterface.php

@@ -124,20 +124,6 @@ public function getMessageQueue();
      */
     public function isClient($identifier);
 
-    /**
-     * Flag if the application instance is a CLI or web based application.
-     *
-     * Helper function, you should use the native PHP functions to detect if it is a CLI application.
-     *
-     * @return  boolean
-     *
-     * @since       4.0.0
-     *
-     * @deprecated  4.0 will be removed in 6.0
-     *              Will be removed without replacement. CLI will be handled by the joomla/console package instead
-     */
-    public function isCli();
-
     /**
      * Get the application identity.
      *

libraries/src/Application/ConsoleApplication.php

@@ -387,23 +387,6 @@ public function isClient($identifier)
         return $this->getName() === $identifier;
     }
 
-    /**
-     * Flag if the application instance is a CLI or web based application.
-     *
-     * Helper function, you should use the native PHP functions to detect if it is a CLI application.
-     *
-     * @return  boolean
-     *
-     * @since       4.0.0
-     *
-     * @deprecated  4.0 will be removed in 6.0
-     *              Will be removed without replacement. CLI will be handled by the joomla/console package instead
-     */
-    public function isCli()
-    {
-        return true;
-    }
-
     /**
      * Sets the session for the application to use, if required.
      *

libraries/src/User/User.php

@@ -10,6 +10,7 @@
 namespace Joomla\CMS\User;
 
 use Joomla\CMS\Access\Access;
+use Joomla\CMS\Application\ConsoleApplication;
 use Joomla\CMS\Event\User\AfterDeleteEvent;
 use Joomla\CMS\Event\User\AfterSaveEvent;
 use Joomla\CMS\Event\User\BeforeDeleteEvent;
@@ -743,15 +744,8 @@ public function save($updateOnly = false)
                 $iAmRehashingSuperadmin = true;
             }
 
-            // Check if we are using a CLI application
-            $isCli = false;
-
-            if (Factory::getApplication()->isCli()) {
-                $isCli = true;
-            }
-
             // We are only worried about edits to this account if I am not a Super Admin.
-            if ($iAmSuperAdmin != true && $iAmRehashingSuperadmin != true && $isCli != true) {
+            if ($iAmSuperAdmin != true && $iAmRehashingSuperadmin != true && !Factory::getApplication() instanceof ConsoleApplication) {
                 // I am not a Super Admin, and this one is, so fail.
                 if (!$isNew && Access::check($this->id, 'core.admin')) {
                     throw new \RuntimeException('User not Super Administrator');