Apply suggestions from code review

YatharthVyas · Phil E. Taylor · YatharthVyas · commit 2bfbcb96b8e6 · 2022-04-02T18:06:01.000+05:30
Co-authored-by: Phil E. Taylor &lt;phil@phil-taylor.com&gt;
diff --git a/administrator/components/com_modules/src/Extension/ModulesComponent.php b/administrator/components/com_modules/src/Extension/ModulesComponent.php
@@ -32,7 +32,10 @@ class ModulesComponent extends MVCComponent implements BootableExtensionInterfac
 	use HTMLRegistryAwareTrait;
 	use WorkflowServiceTrait;
 
-	/** @var array Supported functionality */
+	/** 
+	 * @since  __DEPLOY_VERSION_
+	 * @var array 
+	 */
 	protected $supportedFunctionality = [
 		'core.state' => true,
 	];
@@ -99,9 +102,9 @@ public function getWorkflowContexts(): array
 	{
 		Factory::getLanguage()->load('com_modules', JPATH_ADMINISTRATOR);
 
-		$contexts = array(
+		$contexts = [
 			'com_modules.module'    => Text::_('COM_MODULES')
-		);
+		];
 
 		return $contexts;
 	}
@@ -146,8 +149,6 @@ public function filterTransitions(array $transitions, int $pk): array
 	 */
 	public function getCategoryWorkflowContext(?string $section = null): string
 	{
-		$context = $this->getWorkflowContexts();
-
-		return array_key_first($context);
+		return array_key_first($this->getWorkflowContexts());
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,10 @@ class ModulesComponent extends MVCComponent implements BootableExtensionInterfac`
`32`	`32`	`use HTMLRegistryAwareTrait;`
`33`	`33`	`use WorkflowServiceTrait;`
`34`	`34`
`35`		`- /** @var array Supported functionality */`
	`35`	`+ /**`
	`36`	`+ * @since __DEPLOY_VERSION_`
	`37`	`+ * @var array`
	`38`	`+ */`
`36`	`39`	`protected $supportedFunctionality = [`
`37`	`40`	`'core.state' => true,`
`38`	`41`	`];`
`@@ -99,9 +102,9 @@ public function getWorkflowContexts(): array`
`99`	`102`	`{`
`100`	`103`	`Factory::getLanguage()->load('com_modules', JPATH_ADMINISTRATOR);`
`101`	`104`
`102`		`- $contexts = array(`
	`105`	`+ $contexts = [`
`103`	`106`	`'com_modules.module' => Text::_('COM_MODULES')`
`104`		`- );`
	`107`	`+ ];`
`105`	`108`
`106`	`109`	`return $contexts;`
`107`	`110`	`}`
`@@ -146,8 +149,6 @@ public function filterTransitions(array $transitions, int $pk): array`
`146`	`149`	`*/`
`147`	`150`	`public function getCategoryWorkflowContext(?string $section = null): string`
`148`	`151`	`{`
`149`		`- $context = $this->getWorkflowContexts();`
`150`		`-`
`151`		`- return array_key_first($context);`
	`152`	`+ return array_key_first($this->getWorkflowContexts());`
`152`	`153`	`}`
`153`	`154`	`}`