[5.3] Use str_starts_with function for components (#44868)

Author: joomdonation

administrator/components/com_banners/src/Model/BannerModel.php

@@ -417,7 +417,7 @@ public function save($data)
         if ($createCategory && $this->canCreateCategory()) {
             $category = [
                 // Remove #new# prefix, if exists.
-                'title'     => strpos($data['catid'], '#new#') === 0 ? substr($data['catid'], 5) : $data['catid'],
+                'title'     => str_starts_with($data['catid'], '#new#') ? substr($data['catid'], 5) : $data['catid'],
                 'parent_id' => 1,
                 'extension' => 'com_banners',
                 'language'  => $data['language'],

administrator/components/com_config/src/Dispatcher/Dispatcher.php

@@ -45,7 +45,7 @@ protected function checkAccess(): void
         $view      = $this->input->getCmd('view');
         $component = $this->input->getCmd('component');
 
-        if ($component && (substr($task, 0, 10) === 'component.' || $view === 'component')) {
+        if ($component && (str_starts_with($task, 'component.') || $view === 'component')) {
             // User is changing component settings, check if he has permission to do that
             $canAccess = ConfigHelper::canChangeComponentConfig($component);
         } else {

administrator/components/com_contact/src/Model/ContactModel.php

@@ -292,7 +292,7 @@ public function save($data)
         if ($createCategory && $this->canCreateCategory()) {
             $category = [
                 // Remove #new# prefix, if exists.
-                'title'     => strpos($data['catid'], '#new#') === 0 ? substr($data['catid'], 5) : $data['catid'],
+                'title'     => str_starts_with($data['catid'], '#new#') ? substr($data['catid'], 5) : $data['catid'],
                 'parent_id' => 1,
                 'extension' => 'com_contact',
                 'language'  => $data['language'],

administrator/components/com_content/src/Model/ArticleModel.php

@@ -682,7 +682,7 @@ public function save($data)
         if ($createCategory && $this->canCreateCategory()) {
             $category = [
                 // Remove #new# prefix, if exists.
-                'title'     => strpos($data['catid'], '#new#') === 0 ? substr($data['catid'], 5) : $data['catid'],
+                'title'     => str_starts_with($data['catid'], '#new#') ? substr($data['catid'], 5) : $data['catid'],
                 'parent_id' => 1,
                 'extension' => 'com_content',
                 'language'  => $data['language'],

administrator/components/com_cpanel/src/Controller/DisplayController.php

@@ -75,7 +75,7 @@ public function addModule()
             $appendLink .= '&function=' . $function;
         }
 
-        if (substr($position, 0, 6) != 'cpanel') {
+        if (!str_starts_with($position, 'cpanel')) {
             $position = 'cpanel';
         }
 

administrator/components/com_fields/src/Plugin/FieldsPlugin.php

@@ -343,7 +343,7 @@ public function onContentPrepareForm(Form $form, $data)
     protected function getFormPath(Form $form, $data)
     {
         // Check if the field form is calling us
-        if (strpos($form->getName(), 'com_fields.field') !== 0) {
+        if (!str_starts_with($form->getName(), 'com_fields.field')) {
             return null;
         }
 

administrator/components/com_login/src/Model/LoginModel.php

@@ -90,7 +90,7 @@ public static function getLoginModule($name = 'mod_login', $title = null)
         }
 
         // If we didn't find it, and the name is mod_something, create a dummy object.
-        if (\is_null($result) && substr($name, 0, 4) == 'mod_') {
+        if (\is_null($result) && str_starts_with($name, 'mod_')) {
             $result            = new \stdClass();
             $result->id        = 0;
             $result->title     = '';

administrator/components/com_menus/src/Helper/MenusHelper.php

@@ -72,7 +72,7 @@ public static function getLinkKey($request)
         if (\is_string($request)) {
             $args = [];
 
-            if (strpos($request, 'index.php') === 0) {
+            if (str_starts_with($request, 'index.php')) {
                 parse_str(parse_url(htmlspecialchars_decode($request), PHP_URL_QUERY), $args);
             } else {
                 parse_str($request, $args);
@@ -480,7 +480,7 @@ protected static function installPresetItems($node, $menutype)
                 ];
                 $table->load($keys);
             } elseif ($item->type == 'url' || $item->type == 'component') {
-                if (substr($item->link, 0, 8) === 'special:') {
+                if (str_starts_with($item->link, 'special:')) {
                     $special = substr($item->link, 8);
 
                     if ($special === 'language-forum') {

administrator/components/com_menus/src/Model/MenutypesModel.php

@@ -279,7 +279,7 @@ protected function getTypeOptionsFromMvc($component)
             $view = basename($viewPath);
 
             // Ignore private views.
-            if (strpos($view, '_') !== 0) {
+            if (!str_starts_with($view, '_')) {
                 // Determine if a metadata file exists for the view.
                 $file = $viewPath . '/metadata.xml';
 

administrator/components/com_newsfeeds/src/Model/NewsfeedModel.php

@@ -191,7 +191,7 @@ public function save($data)
         if ($createCategory && $this->canCreateCategory()) {
             $category = [
                 // Remove #new# prefix, if exists.
-                'title'     => strpos($data['catid'], '#new#') === 0 ? substr($data['catid'], 5) : $data['catid'],
+                'title'     => str_starts_with($data['catid'], '#new#') ? substr($data['catid'], 5) : $data['catid'],
                 'parent_id' => 1,
                 'extension' => 'com_newsfeeds',
                 'language'  => $data['language'],