[5.1] menu icon js fix [a11y] (#43116)

brianteeman · web-flow · commit 3698eeaf94d3 · 2024-03-27T18:56:58.000+01:00
diff --git a/build/media_source/mod_menu/js/menu.es6.js b/build/media_source/mod_menu/js/menu.es6.js
@@ -38,7 +38,9 @@
       }
       const spanEl = topLevelEl.querySelector('span');
       if (spanEl) {
-        spanEl.tabIndex = '0';
+        if (spanEl.parentNode.nodeName !== 'A') {
+          spanEl.tabIndex = '0';
+        }
         spanEl.addEventListener('mouseover', topLevelMouseOver(topLevelEl, settings));
         spanEl.addEventListener('mouseout', topLevelMouseOut(topLevelEl, settings));
       }

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,9 @@`
`38`	`38`	`}`
`39`	`39`	`const spanEl = topLevelEl.querySelector('span');`
`40`	`40`	`if (spanEl) {`
`41`		`- spanEl.tabIndex = '0';`
	`41`	`+ if (spanEl.parentNode.nodeName !== 'A') {`
	`42`	`+ spanEl.tabIndex = '0';`
	`43`	`+ }`
`42`	`44`	`spanEl.addEventListener('mouseover', topLevelMouseOver(topLevelEl, settings));`
`43`	`45`	`spanEl.addEventListener('mouseout', topLevelMouseOut(topLevelEl, settings));`
`44`	`46`	`}`