[4.0] Hard coded spaces (#32244)

brianteeman · web-flow · commit 45546718cfa2 · 2021-02-03T15:38:46.000+01:00
It's 2021 and we really should be using css and not spaces for layout. This example PR is for the language layout and replaces the hard coded space with the correct css class of me-1. (because of the new BS5 classes this is RTL aware)
diff --git a/layouts/joomla/content/language.php b/layouts/joomla/content/language.php
@@ -20,7 +20,7 @@
 }
 elseif ($item->language_image)
 {
-	echo HTMLHelper::_('image', 'mod_languages/' . $item->language_image . '.gif', '', null, true) . '&nbsp;' . htmlspecialchars($item->language_title, ENT_COMPAT, 'UTF-8');
+	echo HTMLHelper::_('image', 'mod_languages/' . $item->language_image . '.gif', '', array('class' => 'me-1'), true) . htmlspecialchars($item->language_title, ENT_COMPAT, 'UTF-8');
 }
 elseif ($item->language_title)
 {

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`}`
`21`	`21`	`elseif ($item->language_image)`
`22`	`22`	`{`
`23`		`- echo HTMLHelper::_('image', 'mod_languages/' . $item->language_image . '.gif', '', null, true) . ' ' . htmlspecialchars($item->language_title, ENT_COMPAT, 'UTF-8');`
	`23`	`+ echo HTMLHelper::_('image', 'mod_languages/' . $item->language_image . '.gif', '', array('class' => 'me-1'), true) . htmlspecialchars($item->language_title, ENT_COMPAT, 'UTF-8');`
`24`	`24`	`}`
`25`	`25`	`elseif ($item->language_title)`
`26`	`26`	`{`