Skip to content

Commit 4db771f

Browse files
authored
Tag search for mod-finder (#45744)
Improve a11y for mod finder using the search tag and remove role="search".
1 parent 360d13f commit 4db771f

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

modules/mod_finder/tmpl/default.php

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -61,17 +61,19 @@
6161

6262
?>
6363

64-
<form class="mod-finder js-finder-searchform form-search" action="<?php echo Route::_($route); ?>" method="get" role="search">
65-
<?php echo $output; ?>
66-
67-
<?php $show_advanced = $params->get('show_advanced', 0); ?>
68-
<?php if ($show_advanced == 2) : ?>
69-
<br>
70-
<a href="<?php echo Route::_($route); ?>" class="mod-finder__advanced-link"><?php echo Text::_('COM_FINDER_ADVANCED_SEARCH'); ?></a>
71-
<?php elseif ($show_advanced == 1) : ?>
72-
<div class="mod-finder__advanced js-finder-advanced">
73-
<?php echo HTMLHelper::_('filter.select', $query, $params); ?>
74-
</div>
75-
<?php endif; ?>
76-
<?php echo FinderHelper::getGetFields($route, (int) $params->get('set_itemid', 0)); ?>
77-
</form>
64+
<search>
65+
<form class="mod-finder js-finder-searchform form-search" action="<?php echo Route::_($route); ?>" method="get" aria-label="search">
66+
<?php echo $output; ?>
67+
68+
<?php $show_advanced = $params->get('show_advanced', 0); ?>
69+
<?php if ($show_advanced == 2) : ?>
70+
<br>
71+
<a href="<?php echo Route::_($route); ?>" class="mod-finder__advanced-link"><?php echo Text::_('COM_FINDER_ADVANCED_SEARCH'); ?></a>
72+
<?php elseif ($show_advanced == 1) : ?>
73+
<div class="mod-finder__advanced js-finder-advanced">
74+
<?php echo HTMLHelper::_('filter.select', $query, $params); ?>
75+
</div>
76+
<?php endif; ?>
77+
<?php echo FinderHelper::getGetFields($route, (int) $params->get('set_itemid', 0)); ?>
78+
</form>
79+
</search>

0 commit comments

Comments
 (0)