[4.0] Shouldn't Article Title be H1? (#32448)

* Article Title should be H1

I get that H1 can also be the "Page Heading" aka Menu Title.

But in an article view, you're most likely not gonna wanna have the Menu Title as an H1. Or even if so, it's better to run the risk of having two H1 (if a menu name is displayed), than the article title not being an H1.

I personally don't care as I fix it in template overrides anyway. But as a standard, common practice, my two cents is that Article title should be H1 by default.

* Make Title H1 only if Menu Title is not displayed

* Cleaner code

* Update components/com_content/tmpl/article/default.php

Co-authored-by: Quy <[email protected]>

* Update components/com_content/tmpl/article/default.php

Co-authored-by: Quy <[email protected]>

* separate assignment and echo

as per feedback, to make it more obvious where the value is coming from

Co-authored-by: Quy <[email protected]>

Author: AndySDH

components/com_content/tmpl/article/default.php

@@ -26,6 +26,7 @@
 $canEdit = $params->get('access-edit');
 $user    = Factory::getUser();
 $info    = $params->get('info_block_position', 0);
+$htag    = $this->params->get('show_page_heading') ? 'h2' : 'h1';
 
 // Check if associations are implemented. If they are, define the parameter.
 $assocParam        = (Associations::isEnabled() && $params->get('show_associations'));
@@ -52,9 +53,9 @@
 
 	<?php if ($params->get('show_title')) : ?>
 	<div class="page-header">
-		<h2 itemprop="headline">
+		<<?php echo $htag; ?> itemprop="headline">
 			<?php echo $this->escape($this->item->title); ?>
-		</h2>
+		</<?php echo $htag; ?>>
 		<?php if ($this->item->state == ContentComponent::CONDITION_UNPUBLISHED) : ?>
 			<span class="badge bg-warning text-dark"><?php echo Text::_('JUNPUBLISHED'); ?></span>
 		<?php endif; ?>