Remove useless clone statement (#44843)

`$this->getTable()` always return new table object, so having clone statement here is useless, thus I remove it.

Author: joomdonation

administrator/components/com_banners/src/Model/BannerModel.php

@@ -442,7 +442,7 @@ public function save($data)
         // Alter the name for save as copy
         if ($input->get('task') == 'save2copy') {
             /** @var \Joomla\Component\Banners\Administrator\Table\BannerTable $origTable */
-            $origTable = clone $this->getTable();
+            $origTable = $this->getTable();
             $origTable->load($input->getInt('id'));
 
             if ($data['name'] == $origTable->name) {

administrator/components/com_categories/src/Model/CategoryModel.php

@@ -534,7 +534,7 @@ public function save($data)
 
         // Alter the title for save as copy
         if ($input->get('task') == 'save2copy') {
-            $origTable = clone $this->getTable();
+            $origTable = $this->getTable();
             $origTable->load($input->getInt('id'));
 
             if ($data['title'] == $origTable->title) {

administrator/components/com_contact/src/Model/ContactModel.php

@@ -316,7 +316,7 @@ public function save($data)
 
         // Alter the name for save as copy
         if ($input->get('task') == 'save2copy') {
-            $origTable = clone $this->getTable();
+            $origTable = $this->getTable();
             $origTable->load($input->getInt('id'));
 
             if ($data['name'] == $origTable->name) {

administrator/components/com_fields/src/Model/FieldModel.php

@@ -140,7 +140,7 @@ public function save($data)
         $input = Factory::getApplication()->getInput();
 
         if ($input->get('task') == 'save2copy') {
-            $origTable = clone $this->getTable();
+            $origTable = $this->getTable();
             $origTable->load($input->getInt('id'));
 
             if ($data['title'] == $origTable->title) {

administrator/components/com_guidedtours/src/Model/StepModel.php

@@ -98,7 +98,7 @@ public function save($data)
         }
 
         if ($input->get('task') == 'save2copy') {
-            $origTable = clone $this->getTable();
+            $origTable = $this->getTable();
             $origTable->load($input->getInt('id'));
 
             $data['published'] = 0;

administrator/components/com_guidedtours/src/Model/TourModel.php

@@ -68,7 +68,7 @@ public function save($data)
         }
 
         if ($input->get('task') == 'save2copy') {
-            $origTable = clone $this->getTable();
+            $origTable = $this->getTable();
             $origTable->load($input->getInt('id'));
 
             $data['published'] = 0;

administrator/components/com_newsfeeds/src/Model/NewsfeedModel.php

@@ -215,7 +215,7 @@ public function save($data)
 
         // Alter the name for save as copy
         if ($input->get('task') == 'save2copy') {
-            $origTable = clone $this->getTable();
+            $origTable = $this->getTable();
             $origTable->load($input->getInt('id'));
 
             if ($data['name'] == $origTable->name) {

administrator/components/com_workflow/src/Model/StageModel.php

@@ -117,7 +117,7 @@ public function save($data)
         }
 
         if ($input->get('task') == 'save2copy') {
-            $origTable = clone $this->getTable();
+            $origTable = $this->getTable();
 
             // Alter the title for save as copy
             if ($origTable->load(['title' => $data['title']])) {

administrator/components/com_workflow/src/Model/TransitionModel.php

@@ -167,7 +167,7 @@ public function save($data)
         }
 
         if ($input->get('task') == 'save2copy') {
-            $origTable = clone $this->getTable();
+            $origTable = $this->getTable();
 
             // Alter the title for save as copy
             if ($origTable->load(['title' => $data['title']])) {

administrator/components/com_workflow/src/Model/WorkflowModel.php

@@ -106,7 +106,7 @@ public function save($data)
         }
 
         if ($input->get('task') == 'save2copy') {
-            $origTable = clone $this->getTable();
+            $origTable = $this->getTable();
 
             // Alter the title for save as copy
             if ($origTable->load(['title' => $data['title']])) {