[4.0] Fix categories accordion (#35093)

Author: joomdonation

build/media_source/com_categories/joomla.asset.json

@@ -5,6 +5,14 @@
   "description": "Joomla CMS",
   "license": "GPL-2.0-or-later",
   "assets": [
+    {
+      "name": "com_categories.shared-categories-accordion",
+      "type": "preset",
+      "dependencies": [
+        "com_categories.shared-categories-accordion#style",
+        "com_categories.shared-categories-accordion#script"
+      ]
+    },
     {
       "name": "com_categories.shared-categories-accordion.es5",
       "type": "script",

build/media_source/com_categories/js/shared-categories-accordion.es6.js

@@ -38,7 +38,8 @@ const handleCategoryToggleButtonClick = ({ currentTarget }) => {
     ),
   );
 
-  const target = button.nextElementSibling;
+  const { categoryId } = button.dataset;
+  const target = document.getElementById(`category-${categoryId}`);
   target.toggleAttribute('hidden');
 };
 

components/com_content/tmpl/categories/default.php

@@ -19,8 +19,7 @@
 /** @var Joomla\CMS\WebAsset\WebAssetManager $wa */
 $wa = $this->document->getWebAssetManager();
 $wa->getRegistry()->addExtensionRegistryFile('com_categories');
-$wa->useStyle('com_categories.shared-categories-accordion');
-$wa->useScript('com_categories.shared-categories-accordion');
+$wa->usePreset('com_categories.shared-categories-accordion');
 
 ?>
 <div class="com-content-categories categories-list">

components/com_content/tmpl/categories/default_items.php

@@ -34,6 +34,7 @@
 					<button
 						type="button"
 						id="category-btn-<?php echo $item->id; ?>"
+						data-category-id="<?php echo $item->id; ?>"
 						class="btn btn-secondary btn-sm"
 						aria-expanded="false"
 						aria-label="<?php echo Text::_('JGLOBAL_EXPAND_CATEGORIES'); ?>"