remove query parameters from API route variables (#40998)

Co-authored-by: Allon Moritz <[email protected]>

Author: SniperSister

libraries/src/Router/ApiRouter.php

@@ -99,13 +99,6 @@ public function parseApiRoute($method = 'GET')
         // Get the path from the route and remove and leading or trailing slash.
         $routePath = $this->getRoutePath();
 
-        $query = Uri::getInstance()->getQuery(true);
-
-        // Remove the public key as it is only supported coming from the route definition
-        if (array_key_exists('public', $query)) {
-            unset($query['public']);
-        }
-
         // Iterate through all of the known routes looking for a match.
         foreach ($this->routes as $route) {
             if (\in_array($method, $route->getMethods())) {
@@ -119,11 +112,6 @@ public function parseApiRoute($method = 'GET')
 
                     $controller = preg_split("/[.]+/", $route->getController());
 
-                    /** @deprecated  4.3  will be removed in 5.0
-                     *               Query parameters will not be merged into route variables from 5.0
-                     */
-                    $vars       = array_merge($vars, $query);
-
                     return [
                         'controller' => $controller[0],
                         'task'       => $controller[1],