[5.1] Minor cleanup for modules JS (#42784)

Author: C-Lodder

build/media_source/mod_menu/js/admin-menu.es6.js

@@ -2,8 +2,8 @@
  * @copyright  (C) 2019 Open Source Matters, Inc. <https://www.joomla.org>
  * @license    GNU General Public License version 2 or later; see LICENSE.txt
  */
-const allMenus = document.querySelectorAll('ul.main-nav');
-allMenus.forEach((menu) => {
+
+document.querySelectorAll('ul.main-nav').forEach((menu) => {
   // eslint-disable-next-line no-new, no-undef
   new MetisMenu(menu);
 });
@@ -20,12 +20,10 @@ if (!sidebar) {
 if (sidebar && !sidebar.getAttribute('data-hidden')) {
   // Sidebar
   const menuToggle = document.getElementById('menu-collapse');
-  const firsts = [].slice.call(sidebar.querySelectorAll('.collapse-level-1'));
 
   // Apply 2nd level collapse
-  firsts.forEach((first) => {
-    const seconds = [].slice.call(first.querySelectorAll('.collapse-level-1'));
-    seconds.forEach((second) => {
+  sidebar.querySelectorAll('.collapse-level-1').forEach((first) => {
+    first.querySelectorAll('.collapse-level-1').forEach((second) => {
       if (second) {
         second.classList.remove('collapse-level-1');
         second.classList.add('collapse-level-2');
@@ -40,10 +38,7 @@ if (sidebar && !sidebar.getAttribute('data-hidden')) {
     menuToggleIcon.classList.toggle('icon-toggle-on');
     menuToggleIcon.classList.toggle('icon-toggle-off');
 
-    const listItems = [].slice.call(document.querySelectorAll('.main-nav > li'));
-    listItems.forEach((item) => {
-      item.classList.remove('open');
-    });
+    document.querySelectorAll('.main-nav > li').forEach((item) => item.classList.remove('open'));
 
     const elem = document.querySelector('.child-open');
     if (elem) {
@@ -58,14 +53,11 @@ if (sidebar && !sidebar.getAttribute('data-hidden')) {
   });
 
   // Sidebar Nav
-  const allLinks = wrapper.querySelectorAll('a.no-dropdown, a.collapse-arrow, .menu-dashboard > a');
   const currentUrl = window.location.href;
   const mainNav = document.querySelector('ul.main-nav');
-  const menuParents = [].slice.call(mainNav.querySelectorAll('li.parent > a'));
-  const subMenusClose = [].slice.call(mainNav.querySelectorAll('li.parent .close'));
 
   // Set active class
-  allLinks.forEach((link) => {
+  wrapper.querySelectorAll('a.no-dropdown, a.collapse-arrow, .menu-dashboard > a').forEach((link) => {
     if (
       (!link.href.match(/index\.php$/) && currentUrl.indexOf(link.href) === 0)
       || (link.href.match(/index\.php$/) && currentUrl.match(/index\.php$/))) {
@@ -120,20 +112,15 @@ if (sidebar && !sidebar.getAttribute('data-hidden')) {
     }));
   };
 
-  menuParents.forEach((parent) => {
+  mainNav.querySelectorAll('li.parent > a').forEach((parent) => {
     parent.addEventListener('click', openToggle);
     parent.addEventListener('keyup', openToggle);
   });
 
   // Menu close
-  subMenusClose.forEach((subMenu) => {
+  mainNav.querySelectorAll('li.parent .close').forEach((subMenu) => {
     subMenu.addEventListener('click', () => {
-      const menuChildsOpen = [].slice.call(mainNav.querySelectorAll('.open'));
-
-      menuChildsOpen.forEach((menuChild) => {
-        menuChild.classList.remove('open');
-      });
-
+      mainNav.querySelectorAll('.open').forEach((menuChild) => menuChild.classList.remove('open'));
       mainNav.classList.remove('child-open');
     });
   });

build/media_source/mod_menu/js/menu.es6.js

@@ -27,10 +27,9 @@
       menuHoverClass: 'show-menu',
       dir: 'ltr',
     };
-    const topLevelChilds = nav.querySelectorAll(':scope > li');
 
     // Set tabIndex to -1 so that top_level_childs can't receive focus until menu is open
-    topLevelChilds.forEach((topLevelEl) => {
+    nav.querySelectorAll(':scope > li').forEach((topLevelEl) => {
       const linkEl = topLevelEl.querySelector('a');
       if (linkEl) {
         linkEl.tabIndex = '0';
@@ -139,9 +138,6 @@
   }
 
   document.addEventListener('DOMContentLoaded', () => {
-    const navs = document.querySelectorAll('.nav');
-    [].forEach.call(navs, (nav) => {
-      setupNavigation(nav);
-    });
+    document.querySelectorAll('.nav').forEach((nav) => setupNavigation(nav));
   });
 })();

build/media_source/mod_quickicon/js/quickicon.es6.js

@@ -12,7 +12,7 @@ if (!Joomla) {
   throw new Error('Joomla API was not properly initialized');
 }
 
-Array.from(document.querySelectorAll('.quickicon')).forEach((quickicon) => {
+document.querySelectorAll('.quickicon').forEach((quickicon) => {
   const counter = quickicon.querySelector('.quickicon-amount');
   if (!counter) {
     return;
@@ -30,7 +30,7 @@ Array.from(document.querySelectorAll('.quickicon')).forEach((quickicon) => {
           quickicon.classList.add('error');
         }
 
-        if (Object.prototype.hasOwnProperty.call(response, 'data')) {
+        if (Object.hasOwn(response, 'data')) {
           const name = quickicon.querySelector('.quickicon-name');
           const nameSpan = document.createElement('span');
           quickicon.classList.add(response.data > 0 ? 'warning' : 'success');

build/media_source/mod_sampledata/js/sampledata-process.es6.js

@@ -149,9 +149,7 @@ const sampledataApply = (element) => {
   }
 
   // Turn on the progress container
-  const progressElements = [].slice.call(document.querySelectorAll(`.sampledata-progress-${type}`));
-
-  progressElements.forEach((progressElement) => {
+  document.querySelectorAll(`.sampledata-progress-${type}`).forEach((progressElement) => {
     progressElement.classList.remove('d-none');
   });
 
@@ -167,8 +165,7 @@ const sampledataApply = (element) => {
 const sampleDataWrapper = document.getElementById('sample-data-wrapper');
 
 if (sampleDataWrapper) {
-  const links = [].slice.call(sampleDataWrapper.querySelectorAll('.apply-sample-data'));
-  links.forEach((link) => {
+  sampleDataWrapper.querySelectorAll('.apply-sample-data').forEach((link) => {
     link.addEventListener('click', ({ currentTarget }) => sampledataApply(currentTarget));
   });
 }