[5.3] Change list to array destruct for components code (#44893)

joomdonation · web-flow · commit 81b026906087 · 2025-02-16T00:42:06.000+01:00
diff --git a/administrator/components/com_associations/src/Controller/AssociationController.php b/administrator/components/com_associations/src/Controller/AssociationController.php
@@ -39,7 +39,7 @@ class AssociationController extends FormController
      */
     public function edit($key = null, $urlVar = null)
     {
-        list($extensionName, $typeName) = explode('.', $this->input->get('itemtype', '', 'string'), 2);
+        [$extensionName, $typeName] = explode('.', $this->input->get('itemtype', '', 'string'), 2);
 
         $id = $this->input->get('id', 0, 'int');
 
@@ -67,7 +67,7 @@ public function cancel($key = null)
     {
         $this->checkToken();
 
-        list($extensionName, $typeName) = explode('.', $this->input->get('itemtype', '', 'string'), 2);
+        [$extensionName, $typeName] = explode('.', $this->input->get('itemtype', '', 'string'), 2);
 
         // Only check in, if component item type allows to check out.
         if (AssociationsHelper::typeSupportsCheckout($extensionName, $typeName)) {
diff --git a/administrator/components/com_associations/src/Controller/AssociationsController.php b/administrator/components/com_associations/src/Controller/AssociationsController.php
@@ -94,7 +94,7 @@ public function checkin()
         $this->setRedirect(Route::_('index.php?option=' . $this->option . '&view=' . $this->view_list, false));
 
         // Figure out if the item supports checking and check it in
-        list($extensionName, $typeName) = explode('.', $this->input->get('itemtype'));
+        [$extensionName, $typeName] = explode('.', $this->input->get('itemtype'));
 
         $extension = AssociationsHelper::getSupportedExtension($extensionName);
         $types     = $extension->get('types');
diff --git a/administrator/components/com_associations/src/Dispatcher/Dispatcher.php b/administrator/components/com_associations/src/Dispatcher/Dispatcher.php
@@ -43,7 +43,7 @@ protected function checkAccess()
         $itemType = $this->input->get('itemtype', '', 'string');
 
         if ($itemType !== '') {
-            list($extensionName, $typeName) = explode('.', $itemType);
+            [$extensionName, $typeName] = explode('.', $itemType);
 
             if (!AssociationsHelper::hasSupport($extensionName)) {
                 throw new \Exception(
diff --git a/administrator/components/com_associations/src/Field/ItemlanguageField.php b/administrator/components/com_associations/src/Field/ItemlanguageField.php
@@ -46,7 +46,7 @@ protected function getOptions()
     {
         $input = Factory::getApplication()->getInput();
 
-        list($extensionName, $typeName) = explode('.', $input->get('itemtype', '', 'string'), 2);
+        [$extensionName, $typeName] = explode('.', $input->get('itemtype', '', 'string'), 2);
 
         // Get the extension specific helper method
         $helper = AssociationsHelper::getExtensionHelper($extensionName);
diff --git a/administrator/components/com_associations/src/Model/AssociationsModel.php b/administrator/components/com_associations/src/Model/AssociationsModel.php
@@ -154,7 +154,7 @@ protected function getListQuery()
     {
         $type         = null;
 
-        list($extensionName, $typeName) = explode('.', $this->state->get('itemtype'), 2);
+        [$extensionName, $typeName] = explode('.', $this->state->get('itemtype'), 2);
 
         $extension = AssociationsHelper::getSupportedExtension($extensionName);
         $types     = $extension->get('types');
diff --git a/administrator/components/com_associations/src/View/Associations/HtmlView.php b/administrator/components/com_associations/src/View/Associations/HtmlView.php
@@ -140,7 +140,7 @@ public function display($tpl = null)
         } elseif ($this->state->get('itemtype') != '' && $this->state->get('language') != '') {
             $type = null;
 
-            list($extensionName, $typeName) = explode('.', $this->state->get('itemtype'), 2);
+            [$extensionName, $typeName] = explode('.', $this->state->get('itemtype'), 2);
 
             $extension = AssociationsHelper::getSupportedExtension($extensionName);
 
diff --git a/administrator/components/com_banners/src/Model/BannerModel.php b/administrator/components/com_banners/src/Model/BannerModel.php
@@ -446,9 +446,9 @@ public function save($data)
             $origTable->load($input->getInt('id'));
 
             if ($data['name'] == $origTable->name) {
-                list($name, $alias) = $this->generateNewTitle($data['catid'], $data['alias'], $data['name']);
-                $data['name']       = $name;
-                $data['alias']      = $alias;
+                [$name, $alias] = $this->generateNewTitle($data['catid'], $data['alias'], $data['name']);
+                $data['name']   = $name;
+                $data['alias']  = $alias;
             } else {
                 if ($data['alias'] == $origTable->alias) {
                     $data['alias'] = '';
diff --git a/administrator/components/com_contact/src/Model/ContactModel.php b/administrator/components/com_contact/src/Model/ContactModel.php
@@ -320,9 +320,9 @@ public function save($data)
             $origTable->load($input->getInt('id'));
 
             if ($data['name'] == $origTable->name) {
-                list($name, $alias) = $this->generateNewTitle($data['catid'], $data['alias'], $data['name']);
-                $data['name']       = $name;
-                $data['alias']      = $alias;
+                [$name, $alias] = $this->generateNewTitle($data['catid'], $data['alias'], $data['name']);
+                $data['name']   = $name;
+                $data['alias']  = $alias;
             } else {
                 if ($data['alias'] == $origTable->alias) {
                     $data['alias'] = '';
diff --git a/administrator/components/com_content/src/Model/ArticleModel.php b/administrator/components/com_content/src/Model/ArticleModel.php
@@ -745,9 +745,9 @@ public function save($data)
             }
 
             if ($data['title'] == $origTable->title) {
-                list($title, $alias) = $this->generateNewTitle($data['catid'], $data['alias'], $data['title']);
-                $data['title']       = $title;
-                $data['alias']       = $alias;
+                [$title, $alias] = $this->generateNewTitle($data['catid'], $data['alias'], $data['title']);
+                $data['title']   = $title;
+                $data['alias']   = $alias;
             } elseif ($data['alias'] == $origTable->alias) {
                 $data['alias'] = '';
             }
@@ -768,8 +768,8 @@ public function save($data)
                     $msg = Text::_('COM_CONTENT_SAVE_WARNING');
                 }
 
-                list($title, $alias) = $this->generateNewTitle($data['catid'], $data['alias'], $data['title']);
-                $data['alias']       = $alias;
+                [$title, $alias] = $this->generateNewTitle($data['catid'], $data['alias'], $data['title']);
+                $data['alias']   = $alias;
 
                 if (isset($msg)) {
                     $app->enqueueMessage($msg, 'warning');
diff --git a/administrator/components/com_fields/src/Model/FieldModel.php b/administrator/components/com_fields/src/Model/FieldModel.php
@@ -144,10 +144,10 @@ public function save($data)
             $origTable->load($input->getInt('id'));
 
             if ($data['title'] == $origTable->title) {
-                list($title, $name) = $this->generateNewTitle($data['group_id'], $data['name'], $data['title']);
-                $data['title']      = $title;
-                $data['label']      = $title;
-                $data['name']       = $name;
+                [$title, $name] = $this->generateNewTitle($data['group_id'], $data['name'], $data['title']);
+                $data['title']  = $title;
+                $data['label']  = $title;
+                $data['name']   = $name;
             } else {
                 if ($data['name'] == $origTable->name) {
                     $data['name'] = '';
diff --git a/administrator/components/com_guidedtours/src/Helper/GuidedtoursHelper.php b/administrator/components/com_guidedtours/src/Helper/GuidedtoursHelper.php
@@ -46,7 +46,7 @@ public static function loadTranslationFiles($uid, bool $steps = false)
 
         // The uid has an extension separator so we need to check the extension language files
         if (strpos($uid, '.') > 0) {
-            list($extension, $tourid) = explode('.', $uid, 2);
+            [$extension, $tourid] = explode('.', $uid, 2);
 
             $source = '';
 
diff --git a/administrator/components/com_mails/src/View/Template/HtmlView.php b/administrator/components/com_mails/src/View/Template/HtmlView.php
@@ -90,9 +90,9 @@ public function display($tpl = null)
             throw new GenericDataException(implode("\n", $errors), 500);
         }
 
-        list($extension, $template_id) = explode('.', $this->item->template_id, 2);
-        $fields                        = ['subject', 'body', 'htmlbody'];
-        $this->templateData            = [];
+        [$extension, $template_id] = explode('.', $this->item->template_id, 2);
+        $fields                    = ['subject', 'body', 'htmlbody'];
+        $this->templateData        = [];
 
         MailsHelper::loadTranslationFiles($extension, $this->item->language);
 
diff --git a/administrator/components/com_media/src/Controller/ApiController.php b/administrator/components/com_media/src/Controller/ApiController.php
@@ -276,7 +276,7 @@ public function putFiles()
         }
 
         if ($newPath != null && $newPath !== $adapter . ':' . $path) {
-            list($destinationAdapter, $destinationPath) = explode(':', $newPath, 2);
+            [$destinationAdapter, $destinationPath] = explode(':', $newPath, 2);
 
             if ($move) {
                 $destinationPath = $this->getModel()->move($adapter, $path, $destinationPath, false);
diff --git a/administrator/components/com_media/src/Model/FileModel.php b/administrator/components/com_media/src/Model/FileModel.php
@@ -65,7 +65,7 @@ public function getForm($data = [], $loadData = true)
      */
     public function getFileInformation($path)
     {
-        list($adapter, $path) = explode(':', $path, 2);
+        [$adapter, $path] = explode(':', $path, 2);
 
         return $this->bootComponent('com_media')->getMVCFactory()->createModel('Api', 'Administrator')
             ->getFile($adapter, $path, ['url' => true, 'content' => true]);
diff --git a/administrator/components/com_media/src/Provider/ProviderManager.php b/administrator/components/com_media/src/Provider/ProviderManager.php
@@ -119,7 +119,7 @@ public function getProvider($id)
      */
     public function getAdapter($name)
     {
-        list($provider, $account) = array_pad(explode('-', $name, 2), 2, null);
+        [$provider, $account] = array_pad(explode('-', $name, 2), 2, null);
 
         if ($account == null) {
             throw new ProviderAccountIsEmptyException(Text::_('COM_MEDIA_ERROR_ACCOUNT_NOT_SET'));
diff --git a/administrator/components/com_menus/src/Model/ItemModel.php b/administrator/components/com_menus/src/Model/ItemModel.php
@@ -278,9 +278,9 @@ protected function batchCopy($value, $pks, $contexts)
             $table->home  = 0;
 
             // Alter the title & alias
-            list($title, $alias) = $this->generateNewTitle($table->parent_id, $table->alias, $table->title);
-            $table->title        = $title;
-            $table->alias        = $alias;
+            [$title, $alias] = $this->generateNewTitle($table->parent_id, $table->alias, $table->title);
+            $table->title    = $title;
+            $table->alias    = $alias;
 
             // Check the row.
             if (!$table->check()) {
@@ -1109,7 +1109,7 @@ protected function preprocessForm(Form $form, $data, $group = 'content')
                 // If custom layout, get the xml file from the template folder
                 // template folder is first part of file name -- template:folder
                 if (!$formFile && (strpos($layout, ':') > 0)) {
-                    list($altTmpl, $altLayout) = explode(':', $layout);
+                    [$altTmpl, $altLayout] = explode(':', $layout);
 
                     $templatePath = Path::clean($clientInfo->path . '/templates/' . $altTmpl . '/html/' . $option . '/' . $view . '/' . $altLayout . '.xml');
 
@@ -1380,9 +1380,9 @@ public function save($data)
             $origTable->load($this->getState('item.id'));
 
             if ($table->title === $origTable->title) {
-                list($title, $alias) = $this->generateNewTitle($table->parent_id, $table->alias, $table->title);
-                $table->title        = $title;
-                $table->alias        = $alias;
+                [$title, $alias] = $this->generateNewTitle($table->parent_id, $table->alias, $table->title);
+                $table->title    = $title;
+                $table->alias    = $alias;
             }
 
             if ($table->alias === $origTable->alias) {
diff --git a/administrator/components/com_newsfeeds/src/Model/NewsfeedModel.php b/administrator/components/com_newsfeeds/src/Model/NewsfeedModel.php
@@ -219,9 +219,9 @@ public function save($data)
             $origTable->load($input->getInt('id'));
 
             if ($data['name'] == $origTable->name) {
-                list($name, $alias) = $this->generateNewTitle($data['catid'], $data['alias'], $data['name']);
-                $data['name']       = $name;
-                $data['alias']      = $alias;
+                [$name, $alias] = $this->generateNewTitle($data['catid'], $data['alias'], $data['name']);
+                $data['name']   = $name;
+                $data['alias']  = $alias;
             } else {
                 if ($data['alias'] == $origTable->alias) {
                     $data['alias'] = '';
diff --git a/administrator/components/com_scheduler/src/Helper/ExecRuleHelper.php b/administrator/components/com_scheduler/src/Helper/ExecRuleHelper.php
@@ -111,12 +111,12 @@ public function nextExec(bool $string = true, bool $basisNow = false)
                 $nextExec      = $string ? $nextExec->toSql() : $nextExec;
                 break;
             case 'interval-days':
-                $now                 = Factory::getDate('now', 'UTC');
-                $intervalDays        = $executionRules['interval-days'];
-                $interval            = new \DateInterval('P' . $intervalDays . 'D');
-                $nextExec            = $now->add($interval);
-                $execTime            = $executionRules['exec-time'];
-                list($hour, $minute) = explode(':', $execTime);
+                $now             = Factory::getDate('now', 'UTC');
+                $intervalDays    = $executionRules['interval-days'];
+                $interval        = new \DateInterval('P' . $intervalDays . 'D');
+                $nextExec        = $now->add($interval);
+                $execTime        = $executionRules['exec-time'];
+                [$hour, $minute] = explode(':', $execTime);
                 $nextExec->setTime($hour, $minute);
                 $nextExec = $string ? $nextExec->toSql() : $nextExec;
                 break;
@@ -130,8 +130,8 @@ public function nextExec(bool $string = true, bool $basisNow = false)
                 $nextExecMonth  = $nextExec->format('n');
                 $nextExec->setDate($nextExecYear, $nextExecMonth, $execDay);
 
-                $execTime            = $executionRules['exec-time'];
-                list($hour, $minute) = explode(':', $execTime);
+                $execTime        = $executionRules['exec-time'];
+                [$hour, $minute] = explode(':', $execTime);
                 $nextExec->setTime($hour, $minute);
                 $nextExec = $string ? $nextExec->toSql() : $nextExec;
                 break;
diff --git a/administrator/components/com_tags/src/Model/TagModel.php b/administrator/components/com_tags/src/Model/TagModel.php
@@ -239,9 +239,9 @@ public function save($data)
                 $origTable->load($input->getInt('id'));
 
                 if ($data['title'] == $origTable->title) {
-                    list($title, $alias) = $this->generateNewTitle($data['parent_id'], $data['alias'], $data['title']);
-                    $data['title']       = $title;
-                    $data['alias']       = $alias;
+                    [$title, $alias] = $this->generateNewTitle($data['parent_id'], $data['alias'], $data['title']);
+                    $data['title']   = $title;
+                    $data['alias']   = $alias;
                 } elseif ($data['alias'] == $origTable->alias) {
                     $data['alias'] = '';
                 }
diff --git a/administrator/components/com_workflow/src/Model/StageModel.php b/administrator/components/com_workflow/src/Model/StageModel.php
@@ -121,7 +121,7 @@ public function save($data)
 
             // Alter the title for save as copy
             if ($origTable->load(['title' => $data['title']])) {
-                list($title)   = $this->generateNewTitle(0, '', $data['title']);
+                [$title]       = $this->generateNewTitle(0, '', $data['title']);
                 $data['title'] = $title;
             }
 
diff --git a/administrator/components/com_workflow/src/Model/TransitionModel.php b/administrator/components/com_workflow/src/Model/TransitionModel.php
@@ -171,7 +171,7 @@ public function save($data)
 
             // Alter the title for save as copy
             if ($origTable->load(['title' => $data['title']])) {
-                list($title)   = $this->generateNewTitle(0, '', $data['title']);
+                [$title]       = $this->generateNewTitle(0, '', $data['title']);
                 $data['title'] = $title;
             }
 
diff --git a/administrator/components/com_workflow/src/Model/WorkflowModel.php b/administrator/components/com_workflow/src/Model/WorkflowModel.php
@@ -110,7 +110,7 @@ public function save($data)
 
             // Alter the title for save as copy
             if ($origTable->load(['title' => $data['title']])) {
-                list($title)   = $this->generateNewTitle(0, '', $data['title']);
+                [$title]       = $this->generateNewTitle(0, '', $data['title']);
                 $data['title'] = $title;
             }
 
diff --git a/components/com_contact/src/Service/Router.php b/components/com_contact/src/Service/Router.php
@@ -160,7 +160,7 @@ public function getCategoriesSegment($id, $query)
     public function getContactSegment($id, $query)
     {
         if ($this->noIDs && strpos($id, ':')) {
-            list($void, $segment) = explode(':', $id, 2);
+            [$void, $segment] = explode(':', $id, 2);
 
             return [$void => $segment];
         }
diff --git a/components/com_content/src/Service/Router.php b/components/com_content/src/Service/Router.php
@@ -161,7 +161,7 @@ public function getCategoriesSegment($id, $query)
     public function getArticleSegment($id, $query)
     {
         if ($this->noIDs && strpos($id, ':')) {
-            list($void, $segment) = explode(':', $id, 2);
+            [$void, $segment] = explode(':', $id, 2);
 
             return [$void => $segment];
         }
diff --git a/components/com_newsfeeds/src/Service/Router.php b/components/com_newsfeeds/src/Service/Router.php
@@ -156,7 +156,7 @@ public function getCategoriesSegment($id, $query)
     public function getNewsfeedSegment($id, $query)
     {
         if ($this->noIDs && strpos($id, ':')) {
-            list($void, $segment) = explode(':', $id, 2);
+            [$void, $segment] = explode(':', $id, 2);
 
             return [$void => $segment];
         }

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ class AssociationController extends FormController`
`39`	`39`	`*/`
`40`	`40`	`public function edit($key = null, $urlVar = null)`
`41`	`41`	`{`
`42`		`- list($extensionName, $typeName) = explode('.', $this->input->get('itemtype', '', 'string'), 2);`
	`42`	`+ [$extensionName, $typeName] = explode('.', $this->input->get('itemtype', '', 'string'), 2);`
`43`	`43`
`44`	`44`	`$id = $this->input->get('id', 0, 'int');`
`45`	`45`
`@@ -67,7 +67,7 @@ public function cancel($key = null)`
`67`	`67`	`{`
`68`	`68`	`$this->checkToken();`
`69`	`69`
`70`		`- list($extensionName, $typeName) = explode('.', $this->input->get('itemtype', '', 'string'), 2);`
	`70`	`+ [$extensionName, $typeName] = explode('.', $this->input->get('itemtype', '', 'string'), 2);`
`71`	`71`
`72`	`72`	`// Only check in, if component item type allows to check out.`
`73`	`73`	`if (AssociationsHelper::typeSupportsCheckout($extensionName, $typeName)) {`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ protected function getOptions()`
`46`	`46`	`{`
`47`	`47`	`$input = Factory::getApplication()->getInput();`
`48`	`48`
`49`		`- list($extensionName, $typeName) = explode('.', $input->get('itemtype', '', 'string'), 2);`
	`49`	`+ [$extensionName, $typeName] = explode('.', $input->get('itemtype', '', 'string'), 2);`
`50`	`50`
`51`	`51`	`// Get the extension specific helper method`
`52`	`52`	`$helper = AssociationsHelper::getExtensionHelper($extensionName);`
Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ protected function getListQuery()`
`154`	`154`	`{`
`155`	`155`	`$type = null;`
`156`	`156`
`157`		`- list($extensionName, $typeName) = explode('.', $this->state->get('itemtype'), 2);`
	`157`	`+ [$extensionName, $typeName] = explode('.', $this->state->get('itemtype'), 2);`
`158`	`158`
`159`	`159`	`$extension = AssociationsHelper::getSupportedExtension($extensionName);`
`160`	`160`	`$types = $extension->get('types');`