[4.4] replace deprecated joomla/string inflector (#40317)

* [4.4] replace deprecated joomla/string inflector

* add system tests

* cs

Author: heelc29

libraries/src/MVC/Controller/FormController.php

@@ -9,6 +9,7 @@
 
 namespace Joomla\CMS\MVC\Controller;
 
+use Doctrine\Inflector\InflectorFactory;
 use Joomla\CMS\Application\CMSApplication;
 use Joomla\CMS\Component\ComponentHelper;
 use Joomla\CMS\Form\FormFactoryAwareInterface;
@@ -133,7 +134,7 @@ public function __construct(
 
         // Guess the list view as the plural of the item view.
         if (empty($this->view_list)) {
-            $this->view_list = \Joomla\String\Inflector::getInstance()->toPlural($this->view_item);
+            $this->view_list = InflectorFactory::create()->build()->pluralize($this->view_item);
         }
 
         $this->setFormFactory($formFactory);

libraries/src/MVC/View/ListView.php

@@ -9,6 +9,7 @@
 
 namespace Joomla\CMS\MVC\View;
 
+use Doctrine\Inflector\InflectorFactory;
 use Joomla\CMS\Factory;
 use Joomla\CMS\Language\Text;
 use Joomla\CMS\Layout\FileLayout;
@@ -209,7 +210,7 @@ protected function addToolbar()
         $bar = Toolbar::getInstance('toolbar');
 
         $viewName         = $this->getName();
-        $singularViewName = \Joomla\String\Inflector::getInstance()->toSingular($viewName);
+        $singularViewName = InflectorFactory::create()->build()->singularize($viewName);
 
         ToolbarHelper::title(Text::_($this->toolbarTitle), $this->toolbarIcon);
 

tests/System/integration/administrator/components/com_categories/Category.cy.js

@@ -10,4 +10,12 @@ describe('Test in backend that the category form', () => {
     cy.get('#system-message-container').contains('Category saved.').should('exist');
     cy.contains('Test category');
   });
+
+  it('check redirection to list view', () => {
+    cy.visit('administrator/index.php?option=com_categories&task=category.add&extension=com_content');
+    cy.intercept('index.php?option=com_categories&view=categories&extension=com_content').as('listview');
+    cy.clickToolbarButton('Cancel');
+
+    cy.wait('@listview');
+  });
 });

tests/System/integration/administrator/components/com_content/Article.cy.js

@@ -20,4 +20,12 @@ describe('Test in backend that the article form', () => {
       cy.get('td').contains('Special').should('exist');
     });
   });
+
+  it('check redirection to list view', () => {
+    cy.visit('administrator/index.php?option=com_content&task=article.add');
+    cy.intercept('index.php?option=com_content&view=articles').as('listview');
+    cy.clickToolbarButton('Cancel');
+
+    cy.wait('@listview');
+  });
 });