[5.1] phan: fixes plugins (#43073)

Author: heelc29

.phan/config.php

@@ -49,8 +49,8 @@
     //
     // Note that the **only** effect of choosing `'5.6'` is to infer that functions removed in php 7.0 exist.
     // (See `backward_compatibility_checks` for additional options)
-    // Automatically inferred from composer.json requirement for "php" of "^7.2.5"
-    'target_php_version' => '7.2',
+    // Automatically inferred from composer.json requirement for "php" of "^8.1.0"
+    'target_php_version' => '8.1',
 
     // If enabled, missing properties will be created when
     // they are first seen. If false, we'll report an

administrator/components/com_fields/src/Plugin/FieldsListPlugin.php

@@ -31,7 +31,7 @@ class FieldsListPlugin extends FieldsPlugin
      * @param   \DOMElement  $parent  The field node parent.
      * @param   Form         $form    The form.
      *
-     * @return  \DOMElement
+     * @return  ?\DOMElement
      *
      * @since   3.7.0
      */

administrator/components/com_fields/src/Plugin/FieldsPlugin.php

@@ -201,7 +201,7 @@ public function onCustomFieldsGetTypes()
      * @param   \stdclass  $item     The item.
      * @param   \stdclass  $field    The field.
      *
-     * @return  string
+     * @return  ?string
      *
      * @since   3.7.0
      */
@@ -235,7 +235,7 @@ public function onCustomFieldsPrepareField($context, $item, $field)
      * @param   \DOMElement  $parent  The field node parent.
      * @param   Form         $form    The form.
      *
-     * @return  \DOMElement
+     * @return  ?\DOMElement
      *
      * @since   3.7.0
      */

libraries/src/Changelog/Changelog.php

@@ -122,7 +122,7 @@ class Changelog
     /**
      * Resource handle for the XML Parser
      *
-     * @var    resource
+     * @var    \XMLParser
      * @since  4.0.0
      */
     protected $xmlParser;

libraries/src/Image/Image.php

@@ -137,7 +137,7 @@ public function __construct($source = null)
     /**
      * Get the image resource handle
      *
-     * @return  resource
+     * @return  \GdImage
      *
      * @since   3.8.0
      * @throws  \LogicException if an image has not been loaded into the instance

libraries/src/Image/ImageFilter.php

@@ -21,7 +21,7 @@
 abstract class ImageFilter
 {
     /**
-     * @var    resource  The image resource handle.
+     * @var    \GdImage  The image resource handle.
      * @since  2.5.0
      */
     protected $handle;

libraries/src/Updater/Update.php

@@ -176,7 +176,7 @@ class Update
     /**
      * Resource handle for the XML Parser
      *
-     * @var    resource
+     * @var    \XMLParser
      * @since  3.0.0
      */
     protected $xmlParser;

libraries/src/Updater/UpdateAdapter.php

@@ -32,7 +32,7 @@ abstract class UpdateAdapter extends AdapterInstance
     /**
      * Resource handle for the XML Parser
      *
-     * @var    resource
+     * @var    \XMLParser
      * @since  3.0.0
      */
     protected $xmlParser;

plugins/actionlog/joomla/src/Extension/Joomla.php

@@ -896,7 +896,7 @@ protected function checkLoggable($extension)
      *
      * Method is called after user request to remind their username.
      *
-     * @param   array  $user  Holds the user data.
+     * @param   object  $user  Holds the user data.
      *
      * @return  void
      *
@@ -1127,7 +1127,7 @@ public function onJoomlaAfterUpdate($oldVersion = null)
      *
      * @param   string  $context  The context of the action log
      *
-     * @return  \stdClass  The params
+     * @return  ?\stdClass  The params
      *
      * @since   4.2.0
      */
@@ -1147,7 +1147,7 @@ private function getActionLogParams($context): ?\stdClass
      *
      * Method is called after user request to reset their password.
      *
-     * @param   array  $user  Holds the user data.
+     * @param   object  $user  Holds the user data.
      *
      * @return  void
      *
@@ -1180,7 +1180,7 @@ public function onUserAfterResetRequest($user)
      *
      * Method is called after user complete the reset of their password.
      *
-     * @param   array  $user  Holds the user data.
+     * @param   object  $user  Holds the user data.
      *
      * @return  void
      *

plugins/api-authentication/token/src/Extension/Token.php

@@ -15,7 +15,6 @@
 use Joomla\CMS\Event\User\AuthenticationEvent;
 use Joomla\CMS\Plugin\CMSPlugin;
 use Joomla\CMS\User\UserFactoryAwareTrait;
-use Joomla\Component\Plugins\Administrator\Model\PluginModel;
 use Joomla\Database\DatabaseAwareTrait;
 use Joomla\Database\ParameterType;
 use Joomla\Event\DispatcherInterface;
@@ -327,7 +326,7 @@ private function isTokenEnabledForUser(int $userId): bool
      */
     private function getPluginParameter(string $folder, string $plugin, string $param, $default = null)
     {
-        /** @var PluginModel $model */
+        /** @var \Joomla\Component\Plugins\Administrator\Model\PluginModel $model */
         $model = $this->getApplication()->bootComponent('plugins')
             ->getMVCFactory()->createModel('Plugin', 'Administrator', ['ignore_request' => true]);