Fix module toolbar save buttons (#40381)

Author: joomdonation

administrator/components/com_modules/src/View/Module/HtmlView.php

@@ -116,26 +116,9 @@ function (Toolbar $childBar) {
 
             $toolbar->cancel('module.cancel', 'JTOOLBAR_CANCEL');
         } else {
-            $toolbarButtons = [];
-
             // Can't save the record if it's checked out.
-            if (!$checkedOut) {
-                // Since it's an existing record, check the edit permission.
-                if ($canDo->get('core.edit')) {
-                    $toolbar->apply('module.apply');
-
-                    $toolbarButtons[] = ['save', 'module.save'];
-
-                    // We can save this record, but check the create permission to see if we can return to make a new one.
-                    if ($canDo->get('core.create')) {
-                        $toolbarButtons[] = ['save2new', 'module.save2new'];
-                    }
-                }
-            }
-
-            // If checked out, we can still save
-            if ($canDo->get('core.create')) {
-                $toolbarButtons[] = ['save2copy', 'module.save2copy'];
+            if (!$checkedOut && $canDo->get('core.edit')) {
+                $toolbar->apply('module.apply');
             }
 
             $saveGroup = $toolbar->dropdownButton('save-group');
@@ -148,13 +131,13 @@ function (Toolbar $childBar) use ($checkedOut, $canDo) {
 
                         // We can save this record, but check the create permission to see if we can return to make a new one.
                         if ($canDo->get('core.create')) {
-                            $childBar->save('module.save2new');
+                            $childBar->save2new('module.save2new');
                         }
                     }
 
                     // If checked out, we can still save
                     if ($canDo->get('core.create')) {
-                        $childBar->save('module.save2copy');
+                        $childBar->save2copy('module.save2copy');
                     }
                 }
             );