[3.10] Fix JS error in pre-update-checker (#34115)

degobbis · zero-24 · web-flow · commit d829c116cf4a · 2021-05-30T15:34:58.000+02:00
* Fix JS error in pre-update-checker

Removed unneeded description from manifest_cache in json_encoded string as it breaks JS block in &lt;head&gt; if unclean HTML code is set, preventing pre-update-check from running.

* Add description for Fix

Also find a second place to remove the description.

Co-authored-by: Tobias Zulauf &lt;zero-24@users.noreply.github.com&gt;
diff --git a/administrator/components/com_joomlaupdate/models/default.php b/administrator/components/com_joomlaupdate/models/default.php
@@ -1465,6 +1465,10 @@ public function getNonCoreExtensions()
 		foreach ($rows as $extension)
 		{
 			$decode = json_decode($extension->manifest_cache);
+
+			// Removed description so that CDATA content does not cause javascript error during pre-update check
+			$decode->description = '';
+
 			$this->translateExtensionName($extension);
 			$extension->version = isset($decode->version)
 				? $decode->version
@@ -1535,6 +1539,10 @@ public function getNonCorePlugins($folderFilter = array())
 		foreach ($rows as $plugin)
 		{
 			$decode = json_decode($plugin->manifest_cache);
+
+			// Removed description so that CDATA content does not cause javascript error during pre-update check
+			$decode->description = '';
+
 			$this->translateExtensionName($plugin);
 			$plugin->version = isset($decode->version)
 				? $decode->version
