Backporting event changes (#41484)

Co-authored-by: Allon Moritz <[email protected]>

Author: Fedik

administrator/components/com_scheduler/src/Traits/TaskPluginTrait.php

@@ -109,8 +109,7 @@ public function enhanceTaskItemForm($context, $data = null): bool
     {
         if ($context instanceof EventInterface) {
             /** @var Form $form */
-            $form = $context->getArgument('0');
-            $data = $context->getArgument('1');
+            [$form, $data] = array_values($context->getArguments());
         } elseif ($context instanceof Form) {
             $form = $context;
         } else {

plugins/system/schedulerunner/src/Extension/ScheduleRunner.php

@@ -308,8 +308,7 @@ private function runScheduler(int $id = 0): ?Task
     public function enhanceSchedulerConfig(EventInterface $event): void
     {
         /** @var Form $form */
-        $form = $event->getArgument('0');
-        $data = $event->getArgument('1');
+        [$form, $data] = array_values($event->getArguments());
 
         if (
             $form->getName() !== 'com_config.component'
@@ -344,7 +343,7 @@ public function enhanceSchedulerConfig(EventInterface $event): void
     public function generateWebcronKey(EventInterface $event): void
     {
         /** @var Extension $table */
-        [$context, $table] = $event->getArguments();
+        [$context, $table] = array_values($event->getArguments());
 
         if ($context !== 'com_config.component' || $table->name !== 'com_scheduler') {
             return;

plugins/system/tasknotification/src/Extension/TaskNotification.php

@@ -90,7 +90,7 @@ public static function getSubscribedEvents(): array
     public function injectTaskNotificationFieldset(EventInterface $event): bool
     {
         /** @var Form $form */
-        $form = $event->getArgument('0');
+        [$form] = array_values($event->getArguments());
 
         if ($form->getName() !== 'com_scheduler.task') {
             return true;

plugins/system/webauthn/src/PluginTraits/AdditionalLoginButtons.php

@@ -61,7 +61,7 @@ trait AdditionalLoginButtons
     public function onUserLoginButtons(Event $event): void
     {
         /** @var string $form The HTML ID of the form we are enclosed in */
-        [$form] = $event->getArguments();
+        [$form] = array_values($event->getArguments());
 
         // If we determined we should not inject a button return early
         if (!$this->mustDisplayButton()) {

plugins/system/webauthn/src/PluginTraits/UserDeletion.php

@@ -45,7 +45,7 @@ public function onUserAfterDelete(Event $event): void
          * @var   bool        $success True if user was successfully stored in the database
          * @var   string|null $msg     Message
          */
-        [$user, $success, $msg] = $event->getArguments();
+        [$user, $success, $msg] = array_values($event->getArguments());
 
         if (!$success) {
             $this->returnFromEvent($event, true);

plugins/system/webauthn/src/PluginTraits/UserProfileFields.php

@@ -99,7 +99,7 @@ public function onContentPrepareForm(Event $event)
          * @var   Form  $form The form to be altered.
          * @var   mixed $data The associated data for the form.
          */
-        [$form, $data] = $event->getArguments();
+        [$form, $data] = array_values($event->getArguments());
 
         $name = $form->getName();
 
@@ -160,7 +160,7 @@ public function onContentPrepareData(Event $event): void
          * @var   string|null        $context  The context for the data
          * @var   array|object|null  $data     An object or array containing the data for the form.
          */
-        [$context, $data] = $event->getArguments();
+        [$context, $data] = array_values($event->getArguments());
 
         if (!\in_array($context, ['com_users.profile', 'com_users.user'])) {
             return;

plugins/workflow/featuring/src/Extension/Featuring.php

@@ -89,8 +89,7 @@ public static function getSubscribedEvents(): array
      */
     public function onContentPrepareForm(EventInterface $event)
     {
-        $form = $event->getArgument('0');
-        $data = $event->getArgument('1');
+        [$form, $data] = array_values($event->getArguments());
 
         $context = $form->getName();
 
@@ -371,12 +370,8 @@ public function onContentBeforeChangeFeatured(FeatureEvent $event)
      */
     public function onContentBeforeSave(EventInterface $event)
     {
-        $context = $event->getArgument('0');
-
         /** @var TableInterface $table */
-        $table = $event->getArgument('1');
-        $isNew = $event->getArgument('2');
-        $data  = $event->getArgument('3');
+        [$context, $table, $isNew, $data] = array_values($event->getArguments());
 
         if (!$this->isSupported($context)) {
             return true;

plugins/workflow/notification/src/Extension/Notification.php

@@ -99,8 +99,7 @@ public function __construct(DispatcherInterface $dispatcher, array $config, Lang
      */
     public function onContentPrepareForm(EventInterface $event)
     {
-        $form = $event->getArgument('0');
-        $data = $event->getArgument('1');
+        [$form, $data] = array_values($event->getArguments());
 
         $context = $form->getName();
 

plugins/workflow/publishing/src/Extension/Publishing.php

@@ -87,8 +87,7 @@ public static function getSubscribedEvents(): array
      */
     public function onContentPrepareForm(EventInterface $event)
     {
-        $form = $event->getArgument('0');
-        $data = $event->getArgument('1');
+        [$form, $data] = array_values($event->getArguments());
 
         $context = $form->getName();
 
@@ -353,8 +352,7 @@ public function onWorkflowAfterTransition(WorkflowTransitionEvent $event)
      */
     public function onContentBeforeChangeState(EventInterface $event)
     {
-        $context = $event->getArgument('0');
-        $pks     = $event->getArgument('1');
+        [$form, $pks] = array_values($event->getArguments());
 
         if (!$this->isSupported($context)) {
             return true;
@@ -380,12 +378,8 @@ public function onContentBeforeChangeState(EventInterface $event)
      */
     public function onContentBeforeSave(EventInterface $event)
     {
-        $context = $event->getArgument('0');
-
         /** @var TableInterface $table */
-        $table = $event->getArgument('1');
-        $isNew = $event->getArgument('2');
-        $data  = $event->getArgument('3');
+        [$context, $table, $isNew, $data] = array_values($event->getArguments());
 
         if (!$this->isSupported($context)) {
             return true;