Skip to content

Commit e198c08

Browse files
author
Phil E. Taylor
authored
[4][CloudFlare Issues] Remove validation of the session by IP address (#35509)
> IMHO the commend of @arnepluhar in #35509 should also count as a successful test. He did it as a GitHub code review. The rules about what constitutes a valid test should expand to GitHub code reviews; these didn't even exist when the rules were decided upon back in the day and they make FAR MORE SENSE than comments filed on a PR! Github is configured to allow maintainers merge only if all tests are successful. Thanks all.
1 parent ebad54c commit e198c08

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

libraries/src/Service/Provider/Session.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@
3535
use Joomla\Session\SessionInterface;
3636
use Joomla\Session\Storage\RuntimeStorage;
3737
use Joomla\Session\StorageInterface;
38-
use Joomla\Session\Validator\AddressValidator;
39-
use Joomla\Session\Validator\ForwardedValidator;
4038

4139
/**
4240
* Service provider for the application's session dependency
@@ -329,8 +327,6 @@ private function buildSession(
329327
}
330328

331329
$session = new \Joomla\CMS\Session\Session($storage, $dispatcher, $options);
332-
$session->addValidator(new AddressValidator($input, $session));
333-
$session->addValidator(new ForwardedValidator($input, $session));
334330

335331
return $session;
336332
}

0 commit comments

Comments
 (0)