Fix underline between icon and link in mod_syndicate (#35560)

Author: chmst

modules/mod_syndicate/tmpl/default.php

@@ -9,17 +9,16 @@
 
 defined('_JEXEC') or die;
 
+use Joomla\CMS\HTML\HTMLHelper;
 use Joomla\CMS\Language\Text;
 
-?>
-<a href="<?php echo $link; ?>" class="mod-syndicate syndicate-module">
-	<span class="icon-feed" aria-hidden="true"></span>
-	<?php $class = $params->get('display_text', 1) ? '' : 'class="visually-hidden"'; ?>
-	<span <?php echo $class; ?>>
-		<?php if (str_replace(' ', '', $text) !== '') : ?>
-			<?php echo $text; ?>
-		<?php else : ?>
-			<?php echo Text::_('MOD_SYNDICATE_DEFAULT_FEED_ENTRIES'); ?>
-		<?php endif; ?>
-	</span>
-</a>
+$textClass = ($params->get('display_text', 1) ? '' : 'class="visually-hidden"');
+
+$linkText = '<span class="icon-feed m-1" aria-hidden="true"></span>';
+$linkText .= '<span ' . $textClass . '>' . (!empty($text) ? $text : Text::_('MOD_SYNDICATE_DEFAULT_FEED_ENTRIES')) . '</span>';
+
+$attribs = [
+	'class' => 'mod-syndicate syndicate-module'
+];
+
+echo HTMLHelper::_('link', $link, $linkText, $attribs);