Ensure a language is set in all views (#41021)

Author: laoneo

administrator/components/com_users/src/Helper/Mfa.php

@@ -114,6 +114,7 @@ public static function getConfigurationInterface(User $user): ?string
         $view->returnURL = base64_encode(Uri::getInstance()->toString());
         $view->user      = $user;
         $view->set('forHMVC', true);
+        $view->setLanguage($app->getLanguage());
 
         @ob_start();
 

components/com_config/src/View/Templates/HtmlView.php

@@ -15,6 +15,7 @@
 use Joomla\CMS\MVC\Factory\MVCFactory;
 use Joomla\CMS\MVC\View\HtmlView as BaseHtmlView;
 use Joomla\Component\Config\Administrator\Controller\RequestController;
+use Joomla\Component\Templates\Administrator\View\Style\JsonView;
 
 // phpcs:disable PSR1.Files.SideEffects
 \defined('_JEXEC') or die;
@@ -91,8 +92,10 @@ public function display($tpl = null)
         /** @var MVCFactory $factory */
         $factory = $app->bootComponent('com_templates')->getMVCFactory();
 
+        /** @var JsonView $view */
         $view = $factory->createView('Style', 'Administrator', 'Json');
         $view->setModel($factory->createModel('Style', 'Administrator'), true);
+        $view->setLanguage($app->getLanguage());
 
         $view->document = $this->getDocument();
 

libraries/src/MVC/View/HtmlView.php

@@ -17,6 +17,7 @@
 use Joomla\CMS\Uri\Uri;
 use Joomla\CMS\User\CurrentUserInterface;
 use Joomla\CMS\User\CurrentUserTrait;
+use UnexpectedValueException;
 
 // phpcs:disable PSR1.Files.SideEffects
 \defined('JPATH_PLATFORM') or die;
@@ -368,8 +369,13 @@ public function loadTemplate($tpl = null)
         $file = preg_replace('/[^A-Z0-9_\.-]/i', '', $file);
         $tpl  = isset($tpl) ? preg_replace('/[^A-Z0-9_\.-]/i', '', $tpl) : $tpl;
 
-        // Load the language file for the template
-        $lang = $this->getLanguage();
+        try {
+            // Load the language file for the template
+            $lang = $this->getLanguage();
+        } catch (UnexpectedValueException $e) {
+            $lang = Factory::getApplication()->getLanguage();
+        }
+
         $lang->load('tpl_' . $template->template, JPATH_BASE)
             || $lang->load('tpl_' . $template->parent, JPATH_THEMES . '/' . $template->parent)
             || $lang->load('tpl_' . $template->template, JPATH_THEMES . '/' . $template->template);

tests/System/integration/site/components/com_users/Reset.cy.js

@@ -54,4 +54,10 @@ describe('Test in frontend that the users reset view', () => {
       cy.wrap(mails).should('have.lengthOf', 0);
     });
   });
+
+  it('can show the profile page when logged in', () => {
+    cy.doFrontendLogin();
+    cy.visit('/index.php?option=com_users&view=reset');
+    cy.get('#users-profile-core').should('contain.text', 'Profile');
+  });
 });