Code cleanup (#44572)

Author: janschoenherr

components/com_config/src/Model/ModulesModel.php

@@ -99,7 +99,7 @@ protected function preprocessForm(Form $form, $data, $group = 'content')
             }
 
             // Attempt to load the xml file.
-            if (!$xml = simplexml_load_file($formFile)) {
+            if (!simplexml_load_file($formFile)) {
                 throw new \Exception(Text::_('JERROR_LOADFILE_FAILED'));
             }
         }

components/com_config/src/Model/TemplatesModel.php

@@ -113,7 +113,7 @@ protected function preprocessForm(Form $form, $data, $group = 'content')
         }
 
         // Attempt to load the xml file.
-        if (!$xml = simplexml_load_file($formFile)) {
+        if (!simplexml_load_file($formFile)) {
             throw new \Exception(Text::_('JERROR_LOADFILE_FAILED'));
         }
 

components/com_contact/src/Model/CategoriesModel.php

@@ -139,9 +139,9 @@ public function getItems()
     }
 
     /**
-     * Gets the id of the parent category for the selected list of categories
+     * Gets the parent category for the selected list of categories
      *
-     * @return   integer  The id of the parent category
+     * @return   CategoryNode|null  The parent category
      *
      * @since    1.6.0
      */

components/com_contact/src/Model/ContactModel.php

@@ -252,7 +252,7 @@ public function getItem($pk = null)
                 }
 
                 // Compute access permissions.
-                if (($access = $this->getState('filter.access'))) {
+                if ($this->getState('filter.access')) {
                     // If the access filter has been set, we already know this user can view.
                     $data->params->set('access-view', true);
                 } else {

components/com_contact/src/Service/Router.php

@@ -126,7 +126,7 @@ public function getCategorySegment($id, $query)
 
             if ($this->noIDs) {
                 foreach ($path as &$segment) {
-                    list($id, $segment) = explode(':', $segment, 2);
+                    [, $segment] = explode(':', $segment, 2);
                 }
             }
 

components/com_content/src/Helper/QueryHelper.php

@@ -172,8 +172,6 @@ public static function orderbySecondary($orderby, $orderDate = 'created', ?Datab
      */
     public static function getQueryDate($orderDate, ?DatabaseInterface $db = null)
     {
-        $db = $db ?: Factory::getDbo();
-
         switch ($orderDate) {
             case 'modified':
                 $queryDate = ' CASE WHEN a.modified IS NULL THEN a.created ELSE a.modified END';

components/com_content/src/Model/ArticleModel.php

@@ -249,7 +249,7 @@ public function getItem($pk = null)
                 }
 
                 // Compute view access permissions.
-                if ($access = $this->getState('filter.access')) {
+                if ($this->getState('filter.access')) {
                     // If the access filter has been set, we already know this user can view.
                     $data->params->set('access-view', true);
                 } else {

components/com_content/src/Service/Router.php

@@ -127,7 +127,7 @@ public function getCategorySegment($id, $query)
 
             if ($this->noIDs) {
                 foreach ($path as &$segment) {
-                    list($id, $segment) = explode(':', $segment, 2);
+                    [, $segment] = explode(':', $segment, 2);
                 }
             }
 

components/com_finder/src/Model/SearchModel.php

@@ -113,7 +113,7 @@ public function getItems()
         $results = [];
 
         // Convert the rows to result objects.
-        foreach ($items as $rk => $row) {
+        foreach ($items as $row) {
             // Build the result object.
             if (\is_resource($row->object)) {
                 $result = unserialize(stream_get_contents($row->object));

components/com_newsfeeds/src/Model/NewsfeedModel.php

@@ -179,7 +179,7 @@ public function &getItem($pk = null)
 
                 // Compute access permissions.
 
-                if ($access = $this->getState('filter.access')) {
+                if ($this->getState('filter.access')) {
                     // If the access filter has been set, we already know this user can view.
                     $data->params->set('access-view', true);
                 } else {