Improve System - Skip-To Navigation plugin code (#44857)

Author: joomdonation

plugins/system/skipto/src/Extension/Skipto.php

@@ -73,6 +73,7 @@ public function onAfterDispatch(AfterDispatchEvent $event): void
         $this->loadLanguage();
 
         // Add plugin settings and strings for translations in JavaScript.
+        $language = $app->getLanguage();
         $document->addScriptOptions(
             'skipto-settings',
             [
@@ -87,24 +88,24 @@ public function onAfterDispatch(AfterDispatchEvent $event): void
                         'displayOption' => 'popup',
 
                         // Button labels and messages
-                        'buttonLabel'            => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_TITLE'),
-                        'buttonTooltipAccesskey' => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_ACCESS_KEY'),
+                        'buttonLabel'            => $language->_('PLG_SYSTEM_SKIPTO_TITLE'),
+                        'buttonTooltipAccesskey' => $language->_('PLG_SYSTEM_SKIPTO_ACCESS_KEY'),
 
                         // Menu labels and messages
-                        'landmarkGroupLabel'  => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_LANDMARK'),
-                        'headingGroupLabel'   => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_HEADING'),
-                        'mofnGroupLabel'      => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_HEADING_MOFN'),
-                        'headingLevelLabel'   => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_HEADING_LEVEL'),
-                        'mainLabel'           => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_LANDMARK_MAIN'),
-                        'searchLabel'         => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_LANDMARK_SEARCH'),
-                        'navLabel'            => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_LANDMARK_NAV'),
-                        'regionLabel'         => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_LANDMARK_REGION'),
-                        'asideLabel'          => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_LANDMARK_ASIDE'),
-                        'footerLabel'         => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_LANDMARK_FOOTER'),
-                        'headerLabel'         => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_LANDMARK_HEADER'),
-                        'formLabel'           => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_LANDMARK_FORM'),
-                        'msgNoLandmarksFound' => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_LANDMARK_NONE'),
-                        'msgNoHeadingsFound'  => $app->getLanguage()->_('PLG_SYSTEM_SKIPTO_HEADING_NONE'),
+                        'landmarkGroupLabel'  => $language->_('PLG_SYSTEM_SKIPTO_LANDMARK'),
+                        'headingGroupLabel'   => $language->_('PLG_SYSTEM_SKIPTO_HEADING'),
+                        'mofnGroupLabel'      => $language->_('PLG_SYSTEM_SKIPTO_HEADING_MOFN'),
+                        'headingLevelLabel'   => $language->_('PLG_SYSTEM_SKIPTO_HEADING_LEVEL'),
+                        'mainLabel'           => $language->_('PLG_SYSTEM_SKIPTO_LANDMARK_MAIN'),
+                        'searchLabel'         => $language->_('PLG_SYSTEM_SKIPTO_LANDMARK_SEARCH'),
+                        'navLabel'            => $language->_('PLG_SYSTEM_SKIPTO_LANDMARK_NAV'),
+                        'regionLabel'         => $language->_('PLG_SYSTEM_SKIPTO_LANDMARK_REGION'),
+                        'asideLabel'          => $language->_('PLG_SYSTEM_SKIPTO_LANDMARK_ASIDE'),
+                        'footerLabel'         => $language->_('PLG_SYSTEM_SKIPTO_LANDMARK_FOOTER'),
+                        'headerLabel'         => $language->_('PLG_SYSTEM_SKIPTO_LANDMARK_HEADER'),
+                        'formLabel'           => $language->_('PLG_SYSTEM_SKIPTO_LANDMARK_FORM'),
+                        'msgNoLandmarksFound' => $language->_('PLG_SYSTEM_SKIPTO_LANDMARK_NONE'),
+                        'msgNoHeadingsFound'  => $language->_('PLG_SYSTEM_SKIPTO_HEADING_NONE'),
 
                         // Selectors for landmark and headings sections
                         'headings'  => 'h1, h2, h3',