[6.1] [GSoC 21] Core Enhancement 2 - Incorporation of Modules in Articles-Edit-View #34764

YatharthVyas · 2021-07-12T13:58:43Z

Project Repo PR: joomla-projects/gsoc21_core-enhancements#8
Plan Document: https://docs.google.com/document/d/1Pl8JGa2hkYkmJzQOn9_mS8a4imDmqc2a/edit#heading=h.xzcjfqetxfhr

Summary of Changes

Create Module in Article Edit Screen

Users can add Modules in Articles in Joomla. This is done with the help of the Module xtd-editor Plugin. However, this Plugin opens a Modal that only allows the user to select a pre-existing module, ie. there is no option to add a new module directly in the Article Edit View.
To enhance that, this PR introduces a button to Create Modules directly in the Article Edit View:

Imported Modules Tab

Note: To test this feature, you must enable "Show Imported Modules" in the com_content Global Configuration OR in the Configure Edit Screen Tab. Also, remember that the tab is only visible when you Import a Module and Save it.
- Users have no option to ascertain information about the Modules imported in an article (they can only see the module id)
- Additionally, these modules cannot be directly edited in the Article Edit View.
- There is no user-friendly way to removing these modules. It requires a person to backspace the {loadmoduleid id} string from the article text which may not seem very intuitive to someone that is not tech-savvy. So to make this process more smooth, the users can now remove the tab with the click of a button in this tab

Testing Instructions

Run npm ci to rebuild the assets
Enable the Imported Modules Tab (Global Configuration -> Articles -> Editing Layout -> Show Imported Modules Switcher)
Follow the GIFs above

Documentation Changes Required

I'm not sure

Mentors

@chmst @nibra @bembelimen
(and thanks @richard67)

…yas/gsoc21_core-enhancements into feature-article-module

Co-authored-by: Richard Fath <[email protected]>

…yas/gsoc21_core-enhancements into feature-article-module

HLeithner · 2024-04-24T09:10:20Z

This pull request has been automatically rebased to 5.2-dev.

bascherz · 2024-08-24T17:42:50Z

I have tested this item 🔴 unsuccessfully on dcad97f

I do not know what "npm" is or how to execute it. So that aside, after installing the patch I get the following error when either editing an existing article or creating a new one. I have seen this during testing of other patches during PBF.

An error has occurred.
0 There is no "com_content.admin-article-edit" asset of a "script" type in the registry.
Call Stack

Function Location

1 () JROOT/libraries/src/WebAsset/WebAssetRegistry.php:135
2 Joomla\CMS\WebAsset\WebAssetRegistry->get() JROOT/libraries/src/WebAsset/WebAssetManager.php:274
3 Joomla\CMS\WebAsset\WebAssetManager->useAsset() JROOT/libraries/src/WebAsset/WebAssetManager.php:208
4 Joomla\CMS\WebAsset\WebAssetManager->__call() JROOT/administrator/components/com_content/tmpl/article/edit.php:26
5 include() JROOT/libraries/src/MVC/View/HtmlView.php:416
6 Joomla\CMS\MVC\View\HtmlView->loadTemplate() JROOT/libraries/src/MVC/View/HtmlView.php:204
7 Joomla\CMS\MVC\View\HtmlView->display() JROOT/administrator/components/com_content/src/View/Article/HtmlView.php:135
8 Joomla\Component\Content\Administrator\View\Article\HtmlView->display() JROOT/libraries/src/MVC/Controller/BaseController.php:697
9 Joomla\CMS\MVC\Controller\BaseController->display() JROOT/administrator/components/com_content/src/Controller/DisplayController.php:65
10 Joomla\Component\Content\Administrator\Controller\DisplayController->display() JROOT/libraries/src/MVC/Controller/BaseController.php:730
11 Joomla\CMS\MVC\Controller\BaseController->execute() JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143
12 Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() JROOT/libraries/src/Component/ComponentHelper.php:361
13 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT/libraries/src/Application/AdministratorApplication.php:150
14 Joomla\CMS\Application\AdministratorApplication->dispatch() JROOT/libraries/src/Application/AdministratorApplication.php:195
15 Joomla\CMS\Application\AdministratorApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:306
16 Joomla\CMS\Application\CMSApplication->execute() JROOT/administrator/includes/app.php:58
17 require_once() JROOT/administrator/index.php:32

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34764.}

richard67 · 2024-08-24T17:46:34Z

I have tested this item 🔴 unsuccessfully on dcad97fI do not know what "npm" is or how to execute it. So that aside, after installing the patch I get the following error when either editing an existing article or creating a new one. I have seen this during testing of other patches during PBF.

@bascherz NPM is the Node Package Manager which we use to maintain our javascript dependencies and to generate the js and css from the sources. If you haven't used it and haven't used a prebuild package for testing this PR, then your test is not valid as it is not sufficient just to apply the changes e.g. with the patchtester.

Please change back your test result to "Not tested".

bascherz · 2024-08-24T17:50:31Z

@richard67 I do not know how to do that. I don't see a way to edit a previous post. Should I just repost?

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34764.}

bascherz · 2024-08-24T17:50:59Z

I have not tested this item.

I do not know what "npm" is or how to execute it. So that aside, after installing the patch I get the following error when either editing an existing article or creating a new one. I have seen this during testing of other patches during PBF.

An error has occurred.
0 There is no "com_content.admin-article-edit" asset of a "script" type in the registry.
Call Stack

Function Location

1 () JROOT/libraries/src/WebAsset/WebAssetRegistry.php:135
2 Joomla\CMS\WebAsset\WebAssetRegistry->get() JROOT/libraries/src/WebAsset/WebAssetManager.php:274
3 Joomla\CMS\WebAsset\WebAssetManager->useAsset() JROOT/libraries/src/WebAsset/WebAssetManager.php:208
4 Joomla\CMS\WebAsset\WebAssetManager->__call() JROOT/administrator/components/com_content/tmpl/article/edit.php:26
5 include() JROOT/libraries/src/MVC/View/HtmlView.php:416
6 Joomla\CMS\MVC\View\HtmlView->loadTemplate() JROOT/libraries/src/MVC/View/HtmlView.php:204
7 Joomla\CMS\MVC\View\HtmlView->display() JROOT/administrator/components/com_content/src/View/Article/HtmlView.php:135
8 Joomla\Component\Content\Administrator\View\Article\HtmlView->display() JROOT/libraries/src/MVC/Controller/BaseController.php:697
9 Joomla\CMS\MVC\Controller\BaseController->display() JROOT/administrator/components/com_content/src/Controller/DisplayController.php:65
10 Joomla\Component\Content\Administrator\Controller\DisplayController->display() JROOT/libraries/src/MVC/Controller/BaseController.php:730
11 Joomla\CMS\MVC\Controller\BaseController->execute() JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143
12 Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() JROOT/libraries/src/Component/ComponentHelper.php:361
13 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT/libraries/src/Application/AdministratorApplication.php:150
14 Joomla\CMS\Application\AdministratorApplication->dispatch() JROOT/libraries/src/Application/AdministratorApplication.php:195
15 Joomla\CMS\Application\AdministratorApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:306
16 Joomla\CMS\Application\CMSApplication->execute() JROOT/administrator/includes/app.php:58
17 require_once() JROOT/administrator/index.php:32

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34764.}

HLeithner · 2024-09-02T08:54:27Z

This pull request has been automatically rebased to 5.3-dev.

HLeithner · 2025-03-04T17:23:37Z

This pull request has been automatically rebased to 6.0-dev.

HLeithner · 2025-08-31T12:01:31Z

This pull request has been automatically rebased to 6.1-dev.

YatharthVyas and others added 30 commits June 23, 2021 14:49

init language files

45782b0

init xml form

0da15bd

init plugin php file

12d56a0

Update signature

a6ac050

Merge branch 'feature-article-module' of https://github.com/YatharthV…

a6715a8

…yas/gsoc21_core-enhancements into feature-article-module

language constant for modules tab

431cb80

imported modules tab

3105800

installation sql script

8c36d28

add language constants

27c23bf

show toolbar

3d8b9c6

fetch all modules used in the article

fdf301a

add new tab for imported modules

307300a

add switcher for toggling the imported modules tab

8da56fe

sort sql install script alphabetically

fde75fa

add missing comma

822e539

edit modal script

66f9691

add modal script to assets

de3b3a9

edit module modal

abbcee7

Update administrator/components/com_content/tmpl/article/edit.php

e7a0cdd

Co-authored-by: Richard Fath <[email protected]>

Change heading language constant

6b53d86

Merge branch 'feature-article-module' of https://github.com/YatharthV…

31b3b10

…yas/gsoc21_core-enhancements into feature-article-module

js lint

89ab339

introduce apply button param for Saving

fe446f1

Display a save button in the modal

dd61a88

add remove id language constant

357da31

rename the js file name in assets

de44fae

remove old js file

ecfc63b

js script for modal and remove function

c096b57

add column for removing the module from article

92eac8b

js lint

dcad97f

LadySolveig unassigned coolcat-creations Nov 5, 2023

LadySolveig marked this pull request as draft November 7, 2023 11:40

rdeutz assigned LadySolveig Nov 22, 2023

wilsonge and others added 2 commits November 22, 2023 18:43

Merge branch '5.1-dev' into feature-article-module

d9d7ac1

Merge branch '5.1-dev' into feature-article-module

d1562bd

HLeithner changed the base branch from 5.1-dev to 5.2-dev April 24, 2024 09:10

HLeithner changed the title ~~[5.1] [GSoC 21] Core Enhancement 2 - Incorporation of Modules in Articles-Edit-View~~ [5.2] [GSoC 21] Core Enhancement 2 - Incorporation of Modules in Articles-Edit-View Apr 24, 2024

joomla-cms-bot added the PR-5.2-dev label Apr 24, 2024

Hackwar removed the PR-5.1-dev label Jul 21, 2024

Merge branch '5.2-dev' into feature-article-module

8de72b5

HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:54

HLeithner changed the title ~~[5.2] [GSoC 21] Core Enhancement 2 - Incorporation of Modules in Articles-Edit-View~~ [5.3] [GSoC 21] Core Enhancement 2 - Incorporation of Modules in Articles-Edit-View Sep 2, 2024

joomla-cms-bot added the PR-5.3-dev label Sep 2, 2024

Hackwar removed the PR-5.2-dev label Sep 3, 2024

Merge branch '5.3-dev' into feature-article-module

edf53e8

HLeithner changed the base branch from 5.3-dev to 6.0-dev March 4, 2025 17:23

HLeithner changed the title ~~[5.3] [GSoC 21] Core Enhancement 2 - Incorporation of Modules in Articles-Edit-View~~ [6.0] [GSoC 21] Core Enhancement 2 - Incorporation of Modules in Articles-Edit-View Mar 4, 2025

joomla-cms-bot added the PR-6.0-dev label Mar 4, 2025

rdeutz removed the PR-5.3-dev label Mar 5, 2025

HLeithner changed the base branch from 6.0-dev to 6.1-dev August 31, 2025 12:01

HLeithner changed the title ~~[6.0] [GSoC 21] Core Enhancement 2 - Incorporation of Modules in Articles-Edit-View~~ [6.1] [GSoC 21] Core Enhancement 2 - Incorporation of Modules in Articles-Edit-View Aug 31, 2025

joomla-cms-bot added the PR-6.1-dev label Aug 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[6.1] [GSoC 21] Core Enhancement 2 - Incorporation of Modules in Articles-Edit-View #34764

[6.1] [GSoC 21] Core Enhancement 2 - Incorporation of Modules in Articles-Edit-View #34764

YatharthVyas commented Jul 12, 2021 •

edited

Loading

Uh oh!

HLeithner commented Apr 24, 2024

Uh oh!

bascherz commented Aug 24, 2024

Uh oh!

richard67 commented Aug 24, 2024

Uh oh!

bascherz commented Aug 24, 2024

Uh oh!

bascherz commented Aug 24, 2024

Uh oh!

HLeithner commented Sep 2, 2024

Uh oh!

HLeithner commented Mar 4, 2025

Uh oh!

HLeithner commented Aug 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

[6.1] [GSoC 21] Core Enhancement 2 - Incorporation of Modules in Articles-Edit-View #34764

Are you sure you want to change the base?

[6.1] [GSoC 21] Core Enhancement 2 - Incorporation of Modules in Articles-Edit-View #34764

Conversation

YatharthVyas commented Jul 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Documentation Changes Required

Mentors

Uh oh!

HLeithner commented Apr 24, 2024

Uh oh!

bascherz commented Aug 24, 2024

Function Location

Uh oh!

richard67 commented Aug 24, 2024

Uh oh!

bascherz commented Aug 24, 2024

Uh oh!

bascherz commented Aug 24, 2024

Function Location

Uh oh!

HLeithner commented Sep 2, 2024

Uh oh!

HLeithner commented Mar 4, 2025

Uh oh!

HLeithner commented Aug 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

YatharthVyas commented Jul 12, 2021 •

edited

Loading