From 3adb85adc8d328a1fdad30159c696bfea36c834b Mon Sep 17 00:00:00 2001 From: Fedik Date: Fri, 14 Apr 2023 14:17:59 +0300 Subject: [PATCH 1/2] Log of deprecated WebAssets --- libraries/src/Document/Renderer/Html/ScriptsRenderer.php | 7 +++++++ libraries/src/Document/Renderer/Html/StylesRenderer.php | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/libraries/src/Document/Renderer/Html/ScriptsRenderer.php b/libraries/src/Document/Renderer/Html/ScriptsRenderer.php index 447857765b2fa..9da89e98d8aa4 100644 --- a/libraries/src/Document/Renderer/Html/ScriptsRenderer.php +++ b/libraries/src/Document/Renderer/Html/ScriptsRenderer.php @@ -159,6 +159,13 @@ private function renderElement($item): string if ($asset->getDependencies()) { $attribs['data-asset-dependencies'] = implode(',', $asset->getDependencies()); } + + if ($asset->getOption('deprecated')) { + @trigger_error( + sprintf('Web Asset script [%s] is deprecated. %s', $asset->getName(), $asset->getOption('deprecatedMsg', '')), + E_USER_DEPRECATED + ); + } } } else { $attribs = $item; diff --git a/libraries/src/Document/Renderer/Html/StylesRenderer.php b/libraries/src/Document/Renderer/Html/StylesRenderer.php index 5010ce05e8146..0bdd7a10c0b1d 100644 --- a/libraries/src/Document/Renderer/Html/StylesRenderer.php +++ b/libraries/src/Document/Renderer/Html/StylesRenderer.php @@ -151,6 +151,13 @@ private function renderElement($item): string if ($asset->getDependencies()) { $attribs['data-asset-dependencies'] = implode(',', $asset->getDependencies()); } + + if ($asset->getOption('deprecated')) { + @trigger_error( + sprintf('Web Asset style [%s] is deprecated. %s', $asset->getName(), $asset->getOption('deprecatedMsg', '')), + E_USER_DEPRECATED + ); + } } } else { $attribs = $item; From 37c8839a69c8b185011c798c8bf3141bb9afa87f Mon Sep 17 00:00:00 2001 From: Fedik Date: Mon, 17 Apr 2023 13:54:47 +0300 Subject: [PATCH 2/2] deprecated com_templates.admin-template-compare --- build/media_source/com_templates/joomla.asset.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/build/media_source/com_templates/joomla.asset.json b/build/media_source/com_templates/joomla.asset.json index 3e663870697d0..d0a31ffbe9627 100644 --- a/build/media_source/com_templates/joomla.asset.json +++ b/build/media_source/com_templates/joomla.asset.json @@ -27,7 +27,9 @@ ], "attributes": { "type": "module" - } + }, + "deprecated": true, + "deprecatedMsg": "To be removed in Joomla 5.0" }, { "name": "com_templates.admin-template-toggle-assignment.es5",