Fix no returned states in request (#50)

Author: joostlek

src/python_opensky/opensky.py

@@ -143,10 +143,13 @@ async def get_states(
 
         data = await self._request("states/all", data=params)
 
-        data = {
-            **data,
-            "states": [self._convert_state(state) for state in data["states"]],
-        }
+        if data["states"] is None:
+            data["states"] = []
+        else:
+            data = {
+                **data,
+                "states": [self._convert_state(state) for state in data["states"]],
+            }
 
         self._register_credit_usage(credit_cost)
 
@@ -162,10 +165,13 @@ async def get_own_states(self, time: int = 0) -> StatesResponse:
 
         data = await self._request("states/own", data=params)
 
-        data = {
-            **data,
-            "states": [self._convert_state(state) for state in data["states"]],
-        }
+        if data["states"] is None:
+            data["states"] = []
+        else:
+            data = {
+                **data,
+                "states": [self._convert_state(state) for state in data["states"]],
+            }
 
         return StatesResponse.parse_obj(data)
 

tests/fixtures/unavailable_states.json

@@ -0,0 +1,4 @@
+{
+  "states": null,
+  "time": 1683488744
+}

tests/test_states.py

@@ -64,6 +64,29 @@ async def test_states(
         await opensky.close()
 
 
+async def test_unavailable_states(
+    aresponses: ResponsesMockServer,
+) -> None:
+    """Test retrieving no states."""
+    aresponses.add(
+        OPENSKY_URL,
+        "/api/states/all",
+        "GET",
+        aresponses.Response(
+            status=200,
+            headers={"Content-Type": "application/json"},
+            text=load_fixture("unavailable_states.json"),
+        ),
+    )
+    async with aiohttp.ClientSession() as session:
+        opensky = OpenSky(session=session)
+        response: StatesResponse = await opensky.get_states()
+        assert response.states is not None
+        assert len(response.states) == 0
+        assert response.time == 1683488744
+        await opensky.close()
+
+
 async def test_own_states(
     aresponses: ResponsesMockServer,
 ) -> None:
@@ -87,6 +110,30 @@ async def test_own_states(
         await opensky.close()
 
 
+async def test_unavailable_own_states(
+    aresponses: ResponsesMockServer,
+) -> None:
+    """Test retrieving no own states."""
+    aresponses.add(
+        OPENSKY_URL,
+        "/api/states/own",
+        "GET",
+        aresponses.Response(
+            status=200,
+            headers={"Content-Type": "application/json"},
+            text=load_fixture("unavailable_states.json"),
+        ),
+    )
+    async with aiohttp.ClientSession() as session:
+        opensky = OpenSky(session=session)
+        opensky.authenticate(BasicAuth(login="test", password="test"))
+        response: StatesResponse = await opensky.get_own_states()
+        assert response.states is not None
+        assert len(response.states) == 0
+        assert response.time == 1683488744
+        await opensky.close()
+
+
 async def test_states_with_bounding_box(
     aresponses: ResponsesMockServer,
 ) -> None: