Skip to content

Commit c739f92

Browse files
committed
perf(footer): give images an explicit width and height
1 parent 0a90df5 commit c739f92

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

components/TheFooter.vue

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template>
22
<footer class="footer-section">
3-
<div class="footer-conatiner">
3+
<div class="footer-container">
44
<div class="flex items-center p-8 lg:p-0">
55
<img
66
class="h-5"
@@ -30,19 +30,19 @@
3030
/>
3131
</div>
3232
<div class="lg:flex px-8 pb-8 lg:px-0 lg:pb-0">
33-
<div class="flex items-center justify-end">
33+
<div class="flex items-center justify-end text-center align-middle">
3434
<div class="flex lg:px-5">
3535
<a
3636
href="https://github.com/jordanopensource"
3737
target="_blank"
3838
aria-label="JOSA Github Account"
3939
>
4040
<img
41-
class="h-5 px-2"
41+
class="mx-2"
4242
src="~assets/images/footer/icon-small-github.svg"
4343
alt="Github Account"
44-
width="auto"
45-
height="20"
44+
width="20"
45+
height="55"
4646
loading="lazy"
4747
/></a>
4848
<a
@@ -51,11 +51,11 @@
5151
aria-label="JOSA Twitter Account"
5252
>
5353
<img
54-
class="h-5 px-2"
54+
class="mx-2"
5555
src="~assets/images/footer/icon-small-twitter.svg"
5656
alt="Twitter Account"
57-
width="auto"
58-
height="20"
57+
width="25"
58+
height="60"
5959
loading="lazy"
6060
/></a>
6161
<a
@@ -64,11 +64,11 @@
6464
aria-label="JOSA Facebook Page"
6565
>
6666
<img
67-
class="h-5 pl-2 lg:px-2"
67+
class="ml-2 lg:mx-2"
6868
src="~assets/images/footer/icon-small-fb.svg"
6969
alt="Facebook Page"
70-
width="auto"
71-
height="20"
70+
width="20"
71+
height="55"
7272
loading="lazy"
7373
/>
7474
</a>
@@ -104,10 +104,10 @@ export default {
104104
}
105105
.footer-section {
106106
background-color: #edeeef;
107-
@apply lg:h-64 lg:pt-28 w-11/12 lg:w-full mx-auto lg:mx-0 pb-7 lg:pb-0;
107+
@apply lg:h-64 lg:pt-28 lg:w-full pb-7 lg:pb-0 px-8 md:px-14 lg:px-0;
108108
}
109-
.footer-conatiner {
109+
.footer-container {
110110
background-color: #1a1f21;
111-
@apply lg:flex h-full text-white items-center lg:justify-between lg:px-24 mx-3 lg:mx-0;
111+
@apply lg:flex h-full text-white items-center lg:justify-between lg:px-24;
112112
}
113113
</style>

0 commit comments

Comments
 (0)