Skip to content

Commit 731a5ed

Browse files
committed
dependency updates + some cleanup
1 parent ed9ce09 commit 731a5ed

File tree

3 files changed

+26
-25
lines changed

3 files changed

+26
-25
lines changed

common/src/commonMain/kotlin/com/surrus/common/repository/PeopleInSpaceRepository.kt

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,14 @@ class PeopleInSpaceRepository(
3232

3333
init {
3434
coroutineScope.launch {
35-
// TODO figure out cleaner place to invoke this
35+
// TODO figure out cleaner place to invoke this (needed for web implementatin)
3636
PeopleInSpaceDatabase.Schema.awaitCreate(peopleInSpaceDatabase.driver)
3737
fetchAndStorePeople()
3838
}
3939
}
4040

4141
override fun fetchPeopleAsFlow(): Flow<List<Assignment>> {
42-
// the main reason we need to do this check is that sqldelight isn't currently
43-
// setup for javascript client
44-
return peopleInSpaceQueries?.selectAll(
42+
return peopleInSpaceQueries.selectAll(
4543
mapper = { name, craft, personImageUrl, personBio ->
4644
Assignment(
4745
name = name,
@@ -50,7 +48,7 @@ class PeopleInSpaceRepository(
5048
personBio = personBio
5149
)
5250
}
53-
)?.asFlow()?.mapToList(Dispatchers.Default) ?: flowOf(emptyList())
51+
).asFlow().mapToList(Dispatchers.Default)
5452
}
5553

5654
override suspend fun fetchAndStorePeople() {
@@ -60,8 +58,7 @@ class PeopleInSpaceRepository(
6058

6159
// this is very basic implementation for now that removes all existing rows
6260
// in db and then inserts results from api request
63-
// using "transaction" accelerate the batch of queries, especially inserting
64-
peopleInSpaceQueries?.transaction {
61+
peopleInSpaceQueries.transaction {
6562
peopleInSpaceQueries.deleteAll()
6663
result.people.forEach {
6764
peopleInSpaceQueries.insertItem(
@@ -84,9 +81,14 @@ class PeopleInSpaceRepository(
8481
override fun pollISSPosition(): Flow<IssPosition> {
8582
return flow {
8683
while (true) {
87-
val position = peopleInSpaceApi.fetchISSPosition().iss_position
88-
emit(position)
89-
logger.d { position.toString() }
84+
try {
85+
val position = peopleInSpaceApi.fetchISSPosition().iss_position
86+
emit(position)
87+
logger.d { position.toString() }
88+
} catch (e: Exception) {
89+
// TODO report error up to UI
90+
logger.w(e) { "Exception during pollISSPosition: $e" }
91+
}
9092
delay(POLL_INTERVAL)
9193
}
9294
}

common/src/commonMain/kotlin/com/surrus/common/ui/ISSPositionContent.kt

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,15 @@ fun ISSPositionContent(viewModel: ISSPositionViewModel) {
7171
}
7272
}
7373

74-
Spacer(Modifier.height(16.dp))
74+
//Spacer(Modifier.height(16.dp))
7575

7676
// Map view takes the remaining space
7777
ISSMapView(
7878
Modifier
7979
.fillMaxHeight()
8080
.fillMaxWidth()
81-
.clip(RoundedCornerShape(topStart = 16.dp, topEnd = 16.dp)),
81+
.padding(16.dp)
82+
.clip(RoundedCornerShape(8.dp)),
8283
viewModel
8384
)
8485
}
@@ -89,7 +90,7 @@ fun CoordinateDisplay(label: String, value: String, modifier: Modifier = Modifie
8990
Box(
9091
modifier = modifier
9192
.background(
92-
color = MaterialTheme.colorScheme.primaryContainer,
93+
color = MaterialTheme.colorScheme.background,
9394
shape = RoundedCornerShape(8.dp)
9495
)
9596
.padding(12.dp),
@@ -99,7 +100,7 @@ fun CoordinateDisplay(label: String, value: String, modifier: Modifier = Modifie
99100
Text(
100101
text = label,
101102
style = MaterialTheme.typography.labelMedium,
102-
color = MaterialTheme.colorScheme.onPrimaryContainer
103+
color = MaterialTheme.colorScheme.onBackground
103104
)
104105

105106
Spacer(Modifier.height(4.dp))
@@ -108,7 +109,7 @@ fun CoordinateDisplay(label: String, value: String, modifier: Modifier = Modifie
108109
text = value,
109110
style = MaterialTheme.typography.titleLarge,
110111
fontWeight = FontWeight.Bold,
111-
color = MaterialTheme.colorScheme.onPrimaryContainer
112+
color = MaterialTheme.colorScheme.onBackground
112113
)
113114
}
114115
}

gradle/libs.versions.toml

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,8 @@ compose-multiplatform = "1.8.2"
66
composeUiTooling = "1.4.1"
77
coroutines = "1.10.2"
88
kotlinxSerialization = "1.9.0"
9-
androidGradlePlugin = "8.12.1"
10-
koin = "4.1.0"
11-
koinCompose = "4.1.0"
12-
koinComposeMultiplatform = "4.1.0"
9+
androidGradlePlugin = "8.12.2"
10+
koin = "4.1.1"
1311
ktor = "3.2.3"
1412
osmdroidAndroid = "6.1.20"
1513
osmAndroidCompose = "0.0.5"
@@ -20,14 +18,14 @@ webPackPlugin = "9.1.0"
2018

2119

2220
androidxActivity = "1.10.1"
23-
androidxComposeBom = "2025.08.00"
21+
androidxComposeBom = "2025.08.01"
2422
material3-adaptive = "1.1.0"
2523
material3-adaptive-navigation-suite = "1.3.2"
2624
androidxNavigationCompose = "2.9.3"
2725
uiToolingPreview = "1.9.0"
2826
wearCompose = "1.4.1"
29-
androidxLifecycle = "2.9.2"
30-
androidxLifecycleKMP = "2.9.2"
27+
androidxLifecycle = "2.9.3"
28+
androidxLifecycleKMP = "2.9.3"
3129

3230
coilCompose = "2.7.0"
3331
coilCompose3 = "3.3.0"
@@ -39,7 +37,7 @@ okhttp = "5.1.0"
3937
kermit = "2.0.8"
4038

4139
gradleVersionsPlugin = "0.52.0"
42-
shadowPlugin = "9.0.2"
40+
shadowPlugin = "9.1.0"
4341
skie = "0.10.6"
4442

4543
mcp = "0.6.0"
@@ -107,11 +105,11 @@ glance-appwidget = { module = "androidx.glance:glance-appwidget", version.ref =
107105
androidx-navigation-compose-testing = { module = "androidx.navigation:navigation-testing", version.ref = "androidxNavigationCompose" }
108106

109107
koin-android = { module = "io.insert-koin:koin-android", version.ref = "koin" }
110-
koin-androidx-compose = { module = "io.insert-koin:koin-androidx-compose", version.ref = "koinCompose" }
108+
koin-androidx-compose = { module = "io.insert-koin:koin-androidx-compose", version.ref = "koin" }
111109
koin-core = { module = "io.insert-koin:koin-core", version.ref = "koin" }
112110
koin-test = { module = "io.insert-koin:koin-test", version.ref = "koin" }
113111
koin-test-junit4 = { module = "io.insert-koin:koin-test-junit4", version.ref = "koin" }
114-
koin-compose-multiplatform = { module = "io.insert-koin:koin-compose", version.ref = "koinComposeMultiplatform" }
112+
koin-compose-multiplatform = { module = "io.insert-koin:koin-compose", version.ref = "koin" }
115113

116114
ktor-client-core = { group = "io.ktor", name = "ktor-client-core", version.ref = "ktor" }
117115
ktor-client-json = { group = "io.ktor", name = "ktor-client-json", version.ref = "ktor" }

0 commit comments

Comments
 (0)