Merge pull request github#6371 from github/smowton/admin/test-generator-notice-bad-rows

smowton · web-flow · commit 0049b8e3c40b · 2021-07-27T15:44:01.000+01:00
Add test-case generator check for non-parseable rows
diff --git a/java/ql/src/utils/GenerateFlowTestCase.qll b/java/ql/src/utils/GenerateFlowTestCase.qll
@@ -37,6 +37,9 @@ query string getAParseFailure(string reason) {
   any(TargetSummaryModelCsv target).row(result) and
   any(SummaryModelCsv model).row(result) and
   (
+    not summaryModel(_, _, _, _, _, _, _, _, _, result) and
+    reason = "row could not be parsed"
+    or
     exists(
       string namespace, string type, boolean subtypes, string name, string signature, string ext
     |

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,9 @@ query string getAParseFailure(string reason) {`
`37`	`37`	`any(TargetSummaryModelCsv target).row(result) and`
`38`	`38`	`any(SummaryModelCsv model).row(result) and`
`39`	`39`	`(`
	`40`	`+ not summaryModel(_, _, _, _, _, _, _, _, _, result) and`
	`41`	`+ reason = "row could not be parsed"`
	`42`	`+ or`
`40`	`43`	`exists(`
`41`	`44`	`string namespace, string type, boolean subtypes, string name, string signature, string ext`
`42`	`45`	`\|`