Merge pull request github#12703 from asgerf/rb/api-graphs-trackdef

asgerf · web-flow · commit 008ffea94f10 · 2023-03-31T10:30:18.000+02:00
Ruby: do not depend on trackDefNode in isDef
diff --git a/ruby/ql/lib/codeql/ruby/ApiGraphs.qll b/ruby/ql/lib/codeql/ruby/ApiGraphs.qll
@@ -584,7 +584,7 @@ module API {
       // If a call node is relevant as a use-node, treat its arguments as def-nodes
       argumentStep(_, useCandFwd(), rhs)
       or
-      defStep(_, trackDefNode(_), rhs)
+      defStep(_, defCand(), rhs)
       or
       rhs = any(EntryPoint entry).getASink()
     }

Original file line number	Diff line number	Diff line change
`@@ -584,7 +584,7 @@ module API {`
`584`	`584`	`// If a call node is relevant as a use-node, treat its arguments as def-nodes`
`585`	`585`	`argumentStep(_, useCandFwd(), rhs)`
`586`	`586`	`or`
`587`		`- defStep(_, trackDefNode(_), rhs)`
	`587`	`+ defStep(_, defCand(), rhs)`
`588`	`588`	`or`
`589`	`589`	`rhs = any(EntryPoint entry).getASink()`
`590`	`590`	`}`