Skip to content

Commit 02d6de8

Browse files
yofftausbn
andauthored
Apply suggestions from code review
Co-authored-by: Taus <[email protected]>
1 parent 38daeb4 commit 02d6de8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

python/ql/src/Security/CWE-327/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ This should be kept up to date; the world is moving fast and protocols are being
1212

1313
- `ssl.wrap_socket` is creating insecure connections, use `SSLContext.wrap_socket` instead. [link](https://docs.python.org/3/library/ssl.html#ssl.wrap_socket)
1414
> Deprecated since version 3.7: Since Python 3.2 and 2.7.9, it is recommended to use the `SSLContext.wrap_socket()` instead of `wrap_socket()`. The top-level function is limited and creates an insecure client socket without server name indication or hostname matching.
15-
- Default consteructors are fine, a fluent api is used to constrain possible protocols later.
15+
- Default constructors are fine, a fluent API is used to constrain possible protocols later.
1616

1717
## Current recomendation
1818

python/ql/src/Security/CWE-327/TlsLibraryModel.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ abstract class TlsLibrary extends string {
116116
}
117117

118118
/** The creation of a context with an unspecific protocol version, say TLS, known to have insecure instances. */
119-
DataFlow::CfgNode unspecific_context_creation(ProtocolFamily family) {
119+
ContextCreation unspecific_context_creation(ProtocolFamily family) {
120120
result = default_context_creation()
121121
or
122122
result = specific_context_creation() and

0 commit comments

Comments
 (0)