Skip to content

Commit 07ea006

Browse files
committed
Swift: Add support for CSV modelled sinks as well.
1 parent dba3444 commit 07ea006

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

swift/ql/lib/codeql/swift/security/UncontrolledFormatStringExtensions.qll

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@
44
*/
55

66
import swift
7-
import codeql.swift.StringFormat
8-
import codeql.swift.dataflow.DataFlow
9-
import codeql.swift.dataflow.TaintTracking
7+
private import codeql.swift.StringFormat
8+
private import codeql.swift.dataflow.DataFlow
9+
private import codeql.swift.dataflow.TaintTracking
10+
private import codeql.swift.dataflow.ExternalFlow
1011

1112
/**
1213
* A dataflow sink for uncontrolled format string vulnerabilities.
@@ -26,11 +27,14 @@ class UncontrolledFormatStringAdditionalTaintStep extends Unit {
2627
}
2728

2829
/**
29-
* A default uncontrolled format string sink, that is, the format argument to
30-
* a `FormattingFunctionCall`.
30+
* A default uncontrolled format string sink.
3131
*/
3232
private class DefaultUncontrolledFormatStringSink extends UncontrolledFormatStringSink {
3333
DefaultUncontrolledFormatStringSink() {
34+
// the format argument to a `FormattingFunctionCall`.
3435
this.asExpr() = any(FormattingFunctionCall fc).getFormat()
36+
or
37+
// a sink defined in a Csv model.
38+
sinkNode(this, "uncontrolled-format-string")
3539
}
3640
}

0 commit comments

Comments
 (0)