Skip to content

Commit 08e86fd

Browse files
committed
JS: Make CredentialsFunctionName use nameIndicatesSensitiveData
Someone from JS team needs to verify that this is actually OK.
1 parent e977d6e commit 08e86fd

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

javascript/ql/src/semmle/javascript/security/SensitiveActions.qll

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,7 @@ abstract class SensitiveDataFunctionName extends SensitiveFunctionName {
129129
class CredentialsFunctionName extends SensitiveDataFunctionName {
130130
SensitiveDataClassification classification;
131131

132-
CredentialsFunctionName() {
133-
// TODO: is it by purpose that we don't check whether `this` does not
134-
// match the regexps in `notSensitive`?
135-
this.regexpMatch(maybeSensitive(classification))
136-
}
132+
CredentialsFunctionName() { nameIndicatesSensitiveData(this, classification) }
137133

138134
override SensitiveDataClassification getClassification() { result = classification }
139135
}

0 commit comments

Comments
 (0)