C++: Avoid calling SwitchCase.getAStmt for performance reasons. This turns out to not be needed as the statements inside the switch case will get picked up by the BlockStmt.getAStmt case already.

MathiasVP · MathiasVP · commit 08fa611700b3 · 2021-05-07T11:18:50.000+02:00
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-570/IncorrectAllocationErrorHandling.ql b/cpp/ql/src/experimental/Security/CWE/CWE-570/IncorrectAllocationErrorHandling.ql
@@ -98,8 +98,6 @@ predicate stmtMayThrow(Stmt stmt) {
     stmtMayThrow(switchStmt.getStmt())
   )
   or
-  stmtMayThrow(stmt.(SwitchCase).getAStmt())
-  or
   // NOTE: We don't include `TryStmt` as those exceptions are not "observable" outside the function.
   stmtMayThrow(stmt.(Handler).getBlock())
   or

Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,6 @@ predicate stmtMayThrow(Stmt stmt) {`
`98`	`98`	`stmtMayThrow(switchStmt.getStmt())`
`99`	`99`	`)`
`100`	`100`	`or`
`101`		`- stmtMayThrow(stmt.(SwitchCase).getAStmt())`
`102`		`- or`
`103`	`101`	// NOTE: We don't include `TryStmt` as those exceptions are not "observable" outside the function.
`104`	`102`	`stmtMayThrow(stmt.(Handler).getBlock())`
`105`	`103`	`or`