simplify instanceof usage

Jami Cogswell · Jami Cogswell · commit 09829d7f7ae1 · 2022-10-24T15:49:41.000-04:00
diff --git a/java/ql/lib/semmle/code/java/security/InsufficientKeySize.qll b/java/ql/lib/semmle/code/java/security/InsufficientKeySize.qll
@@ -161,9 +161,7 @@ private class AsymmetricKeyGenerator extends AlgoGeneratorObject {
 }
 
 /** An instance of a `javax.crypto.KeyGenerator`. */
-private class SymmetricKeyGenerator extends AlgoGeneratorObject {
-  SymmetricKeyGenerator() { this instanceof JavaxCryptoKeyGenerator }
-
+private class SymmetricKeyGenerator extends AlgoGeneratorObject instanceof JavaxCryptoKeyGenerator {
   override Expr getAlgoSpec() { result = this.getAlgoSpec() }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -161,9 +161,7 @@ private class AsymmetricKeyGenerator extends AlgoGeneratorObject {`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	/** An instance of a `javax.crypto.KeyGenerator`. */
`164`		`-private class SymmetricKeyGenerator extends AlgoGeneratorObject {`
`165`		`- SymmetricKeyGenerator() { this instanceof JavaxCryptoKeyGenerator }`
`166`		`-`
	`164`	`+private class SymmetricKeyGenerator extends AlgoGeneratorObject instanceof JavaxCryptoKeyGenerator {`
`167`	`165`	`override Expr getAlgoSpec() { result = this.getAlgoSpec() }`
`168`	`166`	`}`
`169`	`167`