Skip to content

Commit 0ade23a

Browse files
RasmusWLyoff
andauthored
Python: Apply suggestions from code review
Co-authored-by: yoff <[email protected]>
1 parent f9383a3 commit 0ade23a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

python/ql/src/semmle/python/frameworks/Cryptodome.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ private module CryptodomeModel {
148148
result in [this.getArg(0), this.getArgByName("plaintext")]
149149
or
150150
methodName in ["decrypt_and_verify"] and
151-
result in [this.getArg(0), this.getArgByName("ciphertext")]
151+
result in [this.getArg(0), this.getArgByName("ciphertext"), this.getArg(1), this.getArgByName("mac_tag")]
152152
}
153153
}
154154

python/ql/test/library-tests/frameworks/crypto/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ You can run the following command to update the tests:
66
rm *.py && cp ../cryptodome/*.py . && sed -i -e 's/Cryptodome/Crypto/' *.py
77
```
88

9-
The original [`pycrypto` PyPI package](https://pypi.org/project/pycrypto/) that provided the `Crypto` Python package has not been updated since 2013, so it is reasonable to assume that people will use the replacement [`pycryptodome` PyPI package](https://pypi.org/project/pycryptodome/) that has a (mostly) compatible API.
9+
The original [`pycrypto` PyPI package](https://pypi.org/project/pycrypto/) that provided the `Crypto` Python package has not been updated since 2013, so it is reasonable to assume that people will use the replacement [`pycryptodome` PyPI package](https://pypi.org/project/pycryptodome/) that also provides a `Crypto` Python package and has a (mostly) compatible API.
1010

1111
The pycryptodome functionality is also available in the [`pycryptodomex` PyPI package](https://pypi.org/project/pycryptodomex/) which provides the `Cryptodome` Python package.
1212

0 commit comments

Comments
 (0)