Improve NestedLoopsSameVariable query performance

tamasvajk · tamasvajk · commit 0aded1549eff · 2021-02-12T09:33:33.000+01:00
diff --git a/csharp/ql/src/Likely Bugs/NestedLoopsSameVariable.ql b/csharp/ql/src/Likely Bugs/NestedLoopsSameVariable.ql
@@ -28,7 +28,8 @@ class NestedForConditions extends SC::StructuralComparisonConfiguration {
 }
 
 private predicate hasChild(Stmt outer, Element child) {
-  outer = child.getParent()
+  outer = child.getParent() and
+  (outer instanceof ForStmt or outer = any(ForStmt f).getBody())
   or
   hasChild(outer, child.getParent())
 }

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,8 @@ class NestedForConditions extends SC::StructuralComparisonConfiguration {`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`private predicate hasChild(Stmt outer, Element child) {`
`31`		`- outer = child.getParent()`
	`31`	`+ outer = child.getParent() and`
	`32`	`+ (outer instanceof ForStmt or outer = any(ForStmt f).getBody())`
`32`	`33`	`or`
`33`	`34`	`hasChild(outer, child.getParent())`
`34`	`35`	`}`