Skip to content

Commit 0b85f3f

Browse files
committed
Address review comments
1 parent f19b104 commit 0b85f3f

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

change-notes/1.25/analysis-csharp.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,10 @@ The following changes in version 1.25 affect C# analysis in all applications.
2424
have type parameters. This means that non-generic nested types inside construced types,
2525
such as `A<int>.B`, no longer are considered unbound generics. (Such nested types do,
2626
however, still have relevant `.getSourceDeclaration()`s, for example `A<>.B`.)
27-
* The data-flow library has been improved, which affects and improves most security queries. Flow
28-
through methods now takes nested field reads/writes into account. For example, the library is
29-
able to track flow from `"taint"` to `Sink()` via the method `GetF2F1()` in
27+
* The data-flow library has been improved, which affects most security queries by potentially
28+
adding more results. Flow through methods now takes nested field reads/writes into account.
29+
For example, the library is able to track flow from `"taint"` to `Sink()` via the method
30+
`GetF2F1()` in
3031
```csharp
3132
class C1
3233
{
@@ -37,13 +38,12 @@ The following changes in version 1.25 affect C# analysis in all applications.
3738
{
3839
C1 F2;
3940

40-
41-
string GetF2F1() => this.F2.F1; // Nested field read
41+
string GetF2F1() => F2.F1; // Nested field read
4242
4343
void M()
4444
{
45-
this.F2 = new C1() { F1 = "taint" };
46-
Sink(this.GetF2F1()); // NEW: "taint" reaches here
45+
F2 = new C1() { F1 = "taint" };
46+
Sink(GetF2F1()); // NEW: "taint" reaches here
4747
}
4848
}
4949
```

change-notes/1.25/analysis-java.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,10 @@ The following changes in version 1.25 affect Java analysis in all applications.
1818

1919
## Changes to libraries
2020

21-
* The data-flow library has been improved, which affects and improves most security queries. Flow
22-
through methods now takes nested field reads/writes into account. For example, the library is
23-
able to track flow from `"taint"` to `sink()` via the method `getF2F1()` in
21+
* The data-flow library has been improved, which affects most security queries by potentially
22+
adding more results. Flow through methods now takes nested field reads/writes into account.
23+
For example, the library is able to track flow from `"taint"` to `sink()` via the method
24+
`getF2F1()` in
2425
```java
2526
class C1 {
2627
String f1;

0 commit comments

Comments
 (0)