Skip to content

Commit 0b89efb

Browse files
committed
Java: model Arrays::addList
1 parent a07af79 commit 0b89efb

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

java/ql/src/semmle/code/java/dataflow/internal/ContainerFlow.qll

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,10 +221,18 @@ private predicate argToQualifierStep(Expr tracked, Expr sink) {
221221

222222
/** Access to a method that passes taint from an argument. */
223223
private predicate argToMethodStep(Expr tracked, MethodAccess sink) {
224-
exists(Method m, int i |
224+
exists(Method m |
225225
m = sink.getMethod() and
226-
taintPreservingArgumentToMethod(m, i) and
227-
tracked = sink.getArgument(i)
226+
(
227+
exists(int i |
228+
taintPreservingArgumentToMethod(m, i) and
229+
tracked = sink.getArgument(i)
230+
)
231+
or
232+
m.getDeclaringType().hasQualifiedName("java.util", "Arrays") and
233+
m.hasName("asList") and
234+
tracked = sink.getAnArgument()
235+
)
228236
)
229237
}
230238

0 commit comments

Comments
 (0)