C++: Remove unnecessary cast

Dave Bartolomeo · Dave Bartolomeo · commit 0bc4b0421dcf · 2021-04-21T12:12:01.000-04:00
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/AliasAnalysis.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/AliasAnalysis.qll
@@ -9,7 +9,7 @@ private class IntValue = Ints::IntValue;
  * effect. If `instr` is a `CallInstruction`, gets that same `CallInstruction`.
  */
 private CallInstruction getPrimaryCall(Instruction instr) {
-  result = instr.(CallInstruction)
+  result = instr
   or
   result = instr.(SideEffectInstruction).getPrimaryInstruction()
 }
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/AliasAnalysis.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/AliasAnalysis.qll
@@ -9,7 +9,7 @@ private class IntValue = Ints::IntValue;
  * effect. If `instr` is a `CallInstruction`, gets that same `CallInstruction`.
  */
 private CallInstruction getPrimaryCall(Instruction instr) {
-  result = instr.(CallInstruction)
+  result = instr
   or
   result = instr.(SideEffectInstruction).getPrimaryInstruction()
 }
diff --git a/csharp/ql/src/experimental/ir/implementation/unaliased_ssa/internal/AliasAnalysis.qll b/csharp/ql/src/experimental/ir/implementation/unaliased_ssa/internal/AliasAnalysis.qll
@@ -9,7 +9,7 @@ private class IntValue = Ints::IntValue;
  * effect. If `instr` is a `CallInstruction`, gets that same `CallInstruction`.
  */
 private CallInstruction getPrimaryCall(Instruction instr) {
-  result = instr.(CallInstruction)
+  result = instr
   or
   result = instr.(SideEffectInstruction).getPrimaryInstruction()
 }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ private class IntValue = Ints::IntValue;`
`9`	`9`	* effect. If `instr` is a `CallInstruction`, gets that same `CallInstruction`.
`10`	`10`	`*/`
`11`	`11`	`private CallInstruction getPrimaryCall(Instruction instr) {`
`12`		`- result = instr.(CallInstruction)`
	`12`	`+ result = instr`
`13`	`13`	`or`
`14`	`14`	`result = instr.(SideEffectInstruction).getPrimaryInstruction()`
`15`	`15`	`}`