Skip to content

Commit 0e183ab

Browse files
committed
Finish comment
1 parent d269a7e commit 0e183ab

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

java/ql/src/experimental/Security/CWE/CWE-352/JsonpInjectionLib.qll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ import semmle.code.java.frameworks.spring.SpringController
1313
abstract class RequestGetMethod extends Method {
1414
RequestGetMethod() {
1515
not exists(MethodAccess ma |
16+
// Exclude apparent GET handlers that read a request entity, because this is the principle of JSONP.
1617
ma.getMethod() instanceof ServletRequestGetBodyMethod and
17-
any(this).polyCalls*(ma.getEnclosingCallable())
18+
this.polyCalls*(ma.getEnclosingCallable())
1819
)
1920
}
2021
}

java/ql/src/experimental/Security/CWE/CWE-598/SensitiveGetQuery.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,4 +76,4 @@ from DataFlow::PathNode source, DataFlow::PathNode sink, SensitiveGetQueryConfig
7676
where c.hasFlowPath(source, sink)
7777
select sink.getNode(), source, sink,
7878
"$@ uses the GET request method to transmit sensitive information.", source.getNode(),
79-
"This request"
79+
"This request"

0 commit comments

Comments
 (0)