Skip to content

Commit 0f6f020

Browse files
committed
Java: Fix models.
1 parent 3c6604d commit 0f6f020

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

java/ql/src/semmle/code/java/dataflow/ExternalFlow.qll

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ private predicate summaryModelCsv(string row) {
274274
"java.io;File;false;toURI;;;Argument[-1];ReturnValue;taint",
275275
"java.io;File;false;toPath;;;Argument[-1];ReturnValue;taint",
276276
"java.nio.file;Path;false;toFile;;;Argument[-1];ReturnValue;taint",
277-
"java.io;Reader;true;readLine;;;Argument[-1];ReturnValue;taint",
277+
"java.io;BufferedReader;true;readLine;;;Argument[-1];ReturnValue;taint",
278278
"java.io;Reader;true;read;();;Argument[-1];ReturnValue;taint",
279279
// arg to return
280280
"java.util;Base64$Encoder;false;encode;(byte[]);;Argument[0];ReturnValue;taint",
@@ -285,8 +285,12 @@ private predicate summaryModelCsv(string row) {
285285
"java.util;Base64$Decoder;false;decode;(ByteBuffer);;Argument[0];ReturnValue;taint",
286286
"java.util;Base64$Decoder;false;decode;(String);;Argument[0];ReturnValue;taint",
287287
"java.util;Base64$Decoder;false;wrap;(InputStream);;Argument[0];ReturnValue;taint",
288-
"org.apache.commons.codec;Encoder;true;encode;;;Argument[0];ReturnValue;taint",
289-
"org.apache.commons.codec;Decoder;true;decode;;;Argument[0];ReturnValue;taint",
288+
"org.apache.commons.codec;Encoder;true;encode;(Object);;Argument[0];ReturnValue;taint",
289+
"org.apache.commons.codec;Decoder;true;decode;(Object);;Argument[0];ReturnValue;taint",
290+
"org.apache.commons.codec;BinaryEncoder;true;encode;(byte[]);;Argument[0];ReturnValue;taint",
291+
"org.apache.commons.codec;BinaryDecoder;true;decode;(byte[]);;Argument[0];ReturnValue;taint",
292+
"org.apache.commons.codec;StringEncoder;true;encode;(String);;Argument[0];ReturnValue;taint",
293+
"org.apache.commons.codec;StringDecoder;true;decode;(String);;Argument[0];ReturnValue;taint",
290294
"org.apache.commons.io;IOUtils;false;buffer;;;Argument[0];ReturnValue;taint",
291295
"org.apache.commons.io;IOUtils;false;readLines;;;Argument[0];ReturnValue;taint",
292296
"org.apache.commons.io;IOUtils;false;readFully;(InputStream,int);;Argument[0];ReturnValue;taint",

0 commit comments

Comments
 (0)