Skip to content

Commit 0f7f465

Browse files
Apply suggestions from code review
Co-authored-by: Anders Schack-Mulligen <[email protected]>
1 parent dae6771 commit 0f7f465

File tree

1 file changed

+18
-18
lines changed
  • java/ql/src/semmle/code/java/frameworks/play

1 file changed

+18
-18
lines changed

java/ql/src/semmle/code/java/frameworks/play/Play.qll

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,32 @@
11
/**
2-
* Provides classes and predicates for working with the `play` package.
2+
* Provides classes and predicates for working with the Play framework.
33
*/
44

55
import java
66

77
/**
8-
* A `play.mvc.Result` class.
8+
* The `play.mvc.Result` class.
99
*/
1010
class PlayMvcResultClass extends Class {
1111
PlayMvcResultClass() { this.hasQualifiedName("play.mvc", "Result") }
1212
}
1313

1414
/**
15-
* A `play.mvc.Results` class.
15+
* The `play.mvc.Results` class.
1616
*/
1717
class PlayMvcResultsClass extends Class {
1818
PlayMvcResultsClass() { this.hasQualifiedName("play.mvc", "Results") }
1919
}
2020

2121
/**
22-
* A `play.mvc.Http$RequestHeader` class.
22+
* The `play.mvc.Http$RequestHeader` class.
2323
*/
2424
class PlayMvcHttpRequestHeader extends RefType {
2525
PlayMvcHttpRequestHeader() { this.hasQualifiedName("play.mvc", "Http$RequestHeader") }
2626
}
2727

2828
/**
29-
* A `play.mvc.BodyParser<>$Of"` annotation.
29+
* A `play.mvc.BodyParser<>$Of` annotation.
3030
*/
3131
class PlayBodyParserAnnotation extends Annotation {
3232
PlayBodyParserAnnotation() { this.getType().hasQualifiedName("play.mvc", "BodyParser<>$Of") }
@@ -42,7 +42,7 @@ class PlayAddCsrfTokenAnnotation extends Annotation {
4242
}
4343

4444
/**
45-
* A member with qualified name `F.Promise<Result>` of package `play.libs.F`.
45+
* The type `play.libs.F.Promise<Result>`.
4646
*/
4747
class PlayAsyncResultPromise extends Member {
4848
PlayAsyncResultPromise() {
@@ -55,7 +55,7 @@ class PlayAsyncResultPromise extends Member {
5555
}
5656

5757
/**
58-
* A type with qualified name `CompletionStage<Result>` of package `java.util.concurrent`.
58+
* The type `java.util.concurrent.CompletionStage<Result>`.
5959
*/
6060
class PlayAsyncResultCompletionStage extends Type {
6161
PlayAsyncResultCompletionStage() {
@@ -65,7 +65,7 @@ class PlayAsyncResultCompletionStage extends Type {
6565
}
6666

6767
/**
68-
* A class which extends PlayMvcController recursively to find all controllers.
68+
* The class `play.mvc.Controller` or a class that transitively extends it.
6969
*/
7070
class PlayController extends Class {
7171
PlayController() {
@@ -74,21 +74,21 @@ class PlayController extends Class {
7474
}
7575

7676
/**
77-
* A method to find PlayFramework controller action methods, these are mapping's to route files.
77+
* A Play framework controller action method. These are mappings to route files.
7878
*
7979
* Sample Route - `POST /login @com.company.Application.login()`.
8080
*
81-
* Example - class get's `index` & `login` as valid action methods.
82-
* ```
81+
* Example - class gets `index` and `login` as valid action methods.
82+
* ```java
8383
* public class Application extends Controller {
84-
* public Result index(String username, String password) {
85-
* return ok("It works!");
86-
* }
84+
* public Result index(String username, String password) {
85+
* return ok("It works!");
86+
* }
8787
*
88-
* public Result login() {
89-
* return ok("Log me In!");
90-
* }
91-
* }
88+
* public Result login() {
89+
* return ok("Log me In!");
90+
* }
91+
* }
9292
* ```
9393
*/
9494
class PlayControllerActionMethod extends Method {

0 commit comments

Comments
 (0)